Auto dark mode in 8.5.x PRO

[shawnyeager]

After upgrading to 8.5.1, I'm seeing a rendering problem with my site when my Mac is in Dark Mode under Mojave.

Here's a post on my site with Hydejack's dark mode disabled in _config.yml (as I prefer to have it), but MacOS dark mode on:

And here is the same post with Hydejack's dark mode enabled and MacOS dark mode on:

[qwtel]

I remember encountering a similar (if not the same) bug during development. I don't recall what exactly the fix was, but it was related to the CSS variables. Make sure you have all the lastest dark-mode files and aren't overriding them.

[shawnyeager]

I also tested on my branch using the 8.5.1 PRO gem (so no local _includes, _js, or _sass, but see the same behavior as above.

[qwtel]

Sorry, I didn't read your issue properly the first time. Yeah that's definitely a bug.

[AlanQuatermain]

An easy way to reproduce this is to set dynamic: false in the config file. With that off, this issue happens until you manually switch it on/off via the button at the top of each page. With it on, everything works as normal. My preference would be to have it react to OS dark mode settings alone without the sunrise/sunset times, so if that's possible that'd be great to have.

[qwtel]

the sunrise/sunset setting is ignored when the browser supports CSS prefers color scheme, so the dynamic setting is necessary to have it react to OS drak mode