Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto dark mode in 8.5.x PRO #176

Closed
shawnyeager opened this issue Aug 25, 2019 · 5 comments
Closed

Auto dark mode in 8.5.x PRO #176

shawnyeager opened this issue Aug 25, 2019 · 5 comments

Comments

@shawnyeager
Copy link

@shawnyeager shawnyeager commented Aug 25, 2019

After upgrading to 8.5.1, I'm seeing a rendering problem with my site when my Mac is in Dark Mode under Mojave.

Here's a post on my site with Hydejack's dark mode disabled in _config.yml (as I prefer to have it), but MacOS dark mode on:

Screenshot 2019-08-24 23 51 32

And here is the same post with Hydejack's dark mode enabled and MacOS dark mode on:

Screenshot 2019-08-24 23 50 59

@qwtel
Copy link
Member

@qwtel qwtel commented Aug 25, 2019

I remember encountering a similar (if not the same) bug during development. I don't recall what exactly the fix was, but it was related to the CSS variables. Make sure you have all the lastest dark-mode files and aren't overriding them.

@shawnyeager
Copy link
Author

@shawnyeager shawnyeager commented Aug 25, 2019

I also tested on my branch using the 8.5.1 PRO gem (so no local _includes, _js, or _sass, but see the same behavior as above.

@qwtel
Copy link
Member

@qwtel qwtel commented Aug 25, 2019

Sorry, I didn't read your issue properly the first time. Yeah that's definitely a bug.

@AlanQuatermain
Copy link

@AlanQuatermain AlanQuatermain commented Aug 28, 2019

An easy way to reproduce this is to set dynamic: false in the config file. With that off, this issue happens until you manually switch it on/off via the button at the top of each page. With it on, everything works as normal. My preference would be to have it react to OS dark mode settings alone without the sunrise/sunset times, so if that's possible that'd be great to have.

@qwtel
Copy link
Member

@qwtel qwtel commented Aug 29, 2019

the sunrise/sunset setting is ignored when the browser supports CSS prefers color scheme, so the dynamic setting is necessary to have it react to OS drak mode

@qwtel qwtel closed this as completed Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants