Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Rename math.h #40

Closed
ghost opened this issue Nov 10, 2020 · 3 comments
Closed

[Suggestion] Rename math.h #40

ghost opened this issue Nov 10, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Nov 10, 2020

Although good compilers and well-configured build systems can make this an impossible problem, old build systems and compilers and weird situations can cause conflicts with the standard library header with the same name.

Work needed?
rename math.h and math.cpp
rename the include in math.cpp and core.h

@Hydr8gon
Copy link
Owner

Good point; I'll have to think of a better name (division? divsqrt? nds_math?).

@Hydr8gon Hydr8gon added the enhancement New feature or request label Nov 16, 2020
@ghost
Copy link
Author

ghost commented Nov 16, 2020

I think divsqrt, ds_math or nds_math should work!? I would vote to nds_math.

@Hydr8gon
Copy link
Owner

I ended up going with div_sqrt, just because nds_math felt a little weird (nothing else has an nds_ prefix).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant