Add tests using ava #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guischdi
suggested changes
Nov 20, 2018
There was a problem hiding this comment.
Hey @bendrucker
sorry for the late response. Thanks a lot your PR!
Here is some (mainly syntactical) issues. Looking forward to your changes!
|
I recognized that you do not use the method shorthand on object initialization ( Also, would you mind using eslint-plugin-ava? Would have helped with some tests linting. |
|
Updated! |
|
Just released a new version 0.1.2! |
Closed
|
Just released a new version 1.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, maintainer of hapi-raven here! Someone asked about support for
@sentry/nodeand I happened upon your package. I'd like to deprecate hapi-raven and direct users over here. I'd like to see this project reach 1.0 before I do that.I've added tests here. I chose
avasince I noticed you'd used it before on a project. They have some major changes coming up in a 1.0 so I figured the prerelease made the most sense.I tried to focus on the major branches/features. Happy to come back and add more tests for the various options in a later PR.