feat: add context.is_first_time_subgraph_is_scheduled to simplify replaying operators #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be cleaner to track the run info in |
MingweiSamuel
approved these changes
Sep 13, 2023
hydroflow/src/scheduled/context.rs
Outdated
| @@ -50,6 +52,13 @@ impl Context { | |||
| self.current_tick_start | |||
| } | |||
|
|
|||
| /// Gets whether this is the first time this subgraph is being scheduled for this tick | |||
| pub fn is_first_time_subgraph_is_scheduled(&self) -> bool { | |||
There was a problem hiding this comment.
Maybe [is_]first_run_this_tick()?
zzlk
force-pushed
the
context-new-tick
branch
from
d828987
to
b72a78c
Compare
MingweiSamuel
added a commit
to MingweiSamuel/hydroflow
that referenced
this pull request
Nov 7, 2023
…ck` check, fixes hydro-project#958 Introduced in hydro-project#906 Also adds more `multiset_delta` tests. Refs: hydro-project#958, hydro-project#906
MingweiSamuel
added a commit
to MingweiSamuel/hydroflow
that referenced
this pull request
Nov 7, 2023
…ck` check, fixes hydro-project#958 Introduced in hydro-project#906 Also adds more `multiset_delta` tests. Refs: hydro-project#958, hydro-project#906
MingweiSamuel
added a commit
to MingweiSamuel/hydroflow
that referenced
this pull request
Nov 7, 2023
…ck` check, fixes hydro-project#958 Introduced in hydro-project#906 Also adds more `multiset_delta` tests. Refs: hydro-project#958, hydro-project#906
MingweiSamuel
added a commit
that referenced
this pull request
Nov 7, 2023
nickjiang2378
pushed a commit
to nickjiang2378/hydroflow
that referenced
this pull request
Jan 24, 2024
nickjiang2378
pushed a commit
to nickjiang2378/hydroflow
that referenced
this pull request
Jan 24, 2024
…ck` check, fixes hydro-project#958 (hydro-project#959) Introduced in hydro-project#906 Also adds more `multiset_delta` tests. Refs: hydro-project#958, hydro-project#906
nickjiang2378
pushed a commit
to nickjiang2378/hydroflow
that referenced
this pull request
Jan 25, 2024
nickjiang2378
pushed a commit
to nickjiang2378/hydroflow
that referenced
this pull request
Jan 25, 2024
…ck` check, fixes hydro-project#958 (hydro-project#959) Introduced in hydro-project#906 Also adds more `multiset_delta` tests. Refs: hydro-project#958, hydro-project#906
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #875