Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some persistent ops still replay infinitely on 'static #1050

Closed
3 of 4 tasks
jhellerstein opened this issue Jan 30, 2024 · 1 comment
Closed
3 of 4 tasks

some persistent ops still replay infinitely on 'static #1050

jhellerstein opened this issue Jan 30, 2024 · 1 comment
Assignees
@MingweiSamuel
Labels
bug Something isn't working hydroflow syntax Hydroflow's custom surface syntax P0 Highest priority
Milestone
0.7 Release

Comments

@jhellerstein
Copy link
Contributor

jhellerstein commented Jan 30, 2024 •
edited by MingweiSamuel
Loading

As surfaced in #800, fold_keyed<'static... causes indefinite replay in a cycle. It should behave like persist as in #906 and check if context.is_first_run_this_tick().

Need to check if the same problem arises with fold and reduce and reduce_keyed and lattice_fold and _lattice_fold_batch.

Fixed?
@jhellerstein jhellerstein added this to the 0.7 Release milestone Jan 30, 2024
@MingweiSamuel MingweiSamuel changed the title persistent ops replay infinitely on 'static some persistent ops still replay infinitely on 'static Jan 31, 2024
@MingweiSamuel MingweiSamuel added bug Something isn't working hydroflow syntax Hydroflow's custom surface syntax labels Jan 31, 2024
@MingweiSamuel
Copy link
Member

And _lattice_join_fused_join has the problem

MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Feb 2, 2024
@MingweiSamuel
fix(hydroflow_lang): fix coloring of _lattice_join_fused_join, fix h…
d9d5788 
…ydro-project#943

fixup hydro-project#1026

exacerbates bug: hydro-project#1050 (comment)
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Feb 2, 2024
@MingweiSamuel
fix(hydroflow_lang): fix coloring of _lattice_join_fused_join, fix h…
d9e4616 
…ydro-project#943

fixup hydro-project#1026

exacerbates bug: hydro-project#1050 (comment)
MingweiSamuel added a commit that referenced this issue Feb 2, 2024
@MingweiSamuel
fix(hydroflow_lang): fix coloring of _lattice_join_fused_join, fix #…
a572dee 
…943 (#1055)

fixup #1026

exacerbates bug: #1050 (comment)
@MingweiSamuel MingweiSamuel added the P0 Highest priority label Feb 5, 2024
This was referenced Feb 5, 2024
Closed
Closed
@MingweiSamuel MingweiSamuel mentioned this issue Feb 26, 2024
Closed
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Mar 1, 2024
@MingweiSamuel
add hydroflow scheduling spin test for hydro-project#1050 hydro-proje…
fa6d6ed 
…ct#800
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Mar 1, 2024
@MingweiSamuel
fixup! add hydroflow scheduling spin test for hydro-project#1050 hydr…
4b1b24d 
…o-project#800
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Mar 1, 2024
@MingweiSamuel
fix hydro-project#1050 for fold_keyed wip?
a3adba0
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Mar 4, 2024
@MingweiSamuel
test(hydroflow): add hydroflow scheduling spin test for hydro-project…
7319ea9 
…#1050 hydro-project#800
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Mar 4, 2024
@MingweiSamuel
fix(hydroflow): hydro-project#1050 for fold_keyed
fa28525
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Mar 4, 2024
@MingweiSamuel
fix(hydroflow): hydro-project#1050 for fold_keyed
1cbddfe
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Mar 4, 2024
@MingweiSamuel
fix(hydroflow): hydro-project#1050 for fold_keyed
05b9f17
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Mar 4, 2024
@MingweiSamuel
fix(hydroflow): hydro-project#1050 for fold_keyed
14debb8
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Mar 4, 2024
@MingweiSamuel
test(hydroflow): add hydroflow scheduling spin test for hydro-project…
4a5953b 
…#1050 hydro-project#800 (hydro-project#1086)
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Mar 4, 2024
@MingweiSamuel
fix(hydroflow): hydro-project#1050 for fold_keyed (hydro-project#1086)
51d5331 
fix hydro-project#800
MingweiSamuel added a commit that referenced this issue Mar 4, 2024
@MingweiSamuel
test(hydroflow): add hydroflow scheduling spin test for #1050 #800 (#…
118a563 
…1086)
MingweiSamuel added a commit that referenced this issue Mar 4, 2024
@MingweiSamuel
fix(hydroflow): #1050 for fold_keyed (#1086)
b7c7a93 
fix #800
MingweiSamuel added a commit that referenced this issue Mar 4, 2024
@MingweiSamuel
fix(hydroflow): #1050 for fold_keyed (#1086)
f8311db 
fix #800
This was referenced Mar 26, 2024
Closed
Closed
This was referenced Mar 26, 2024
Closed
Closed
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Apr 26, 2024
@MingweiSamuel
fix(hydroflow_lang): fix hydro-project#1050 for fold_keyed
5cd3b23
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Apr 26, 2024
@MingweiSamuel
fix(hydroflow_lang): fix hydro-project#1050 for fold_keyed
4f6aa07
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Apr 26, 2024
@MingweiSamuel
fix(hydroflow_lang): fix hydro-project#1050 for reduce_keyed
91597d5
@MingweiSamuel MingweiSamuel mentioned this issue Apr 26, 2024
Closed
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Apr 26, 2024
@MingweiSamuel
fix(hydroflow_lang): fix hydro-project#1050 for reduce_keyed (hydro…
2db9151 
…-project#1176)
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Apr 26, 2024
@MingweiSamuel
fix(hydroflow_lang): fix hydro-project#1050 for reduce_keyed, fix h…
f1f0e62 
…ydro-project#1050 (hydro-project#1176)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MingweiSamuel MingweiSamuel

Labels
bug Something isn't working hydroflow syntax Hydroflow's custom surface syntax P0 Highest priority
Projects
None yet
Milestone
0.7 Release
Development

No branches or pull requests
2 participants
@jhellerstein @MingweiSamuel