Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jack Transport not active when "auto" engine is used (even if it selects JACK) #392

Closed
trebmuh opened this issue Aug 9, 2016 · 4 comments
Closed

Jack Transport not active when "auto" engine is used (even if it selects JACK) #392

trebmuh opened this issue Aug 9, 2016 · 4 comments

Comments

@trebmuh
Copy link
Member

trebmuh commented Aug 9, 2016 •
edited

I was just reading at this discussion: #379 and playing around with Hydrogen when I suddenly faced up a strange behavior:

Screencast: http://download.tuxfamily.org/librazik/volatile/hydrogen-issue392.mp4

Comments about the screencast:

  1. Hydrogen is first set up menu -> Tools -> Preferences -> audio system : auto and is using JACK as you can see in the Catia connexion manager. The JACK-transport buttons are not here.
  2. Then I'm setting Hydrogen to menu -> Tools -> Preferences -> audio system : Jack, and restarting the output. You can see that Hydrogen flickers in Catia which indicates that the output is effectively restarted. Then, I'm closing the Preferences window, and the JACK-transport buttons appear.
  3. Then, I'm resetting Hydrogen to menu -> Tools -> Preferences -> audio system : auto and restarting the output. Once again, Catia flickers which indicates that the Hydrogen output in "auto" mode is restarted and is choosing to use JACK. Then, I'm closing the Preferences window, and the JACK-transport buttons disappear.

What would I be expecting ?

As a user, I'd expect Hydrogen to show my the JACK transport controls whether I select manually the audio-engine to be JACK, or if the "auto" mode is choosing JACK as the audio engine.

Hope that helps.
mauser added a commit that referenced this issue Aug 11, 2016
@mauser
Bugfix for #392: Show jack transport buttons even if 'auto' is set as
85cd741 
the audio driver in the preferences dialog.

Use the class name of the audio driver to detect if jack driver is
active.
@mauser
Copy link
Member

mauser commented Aug 11, 2016

Should be fixed now..

@trebmuh
Copy link
Member Author

trebmuh commented Aug 11, 2016 •
edited

Fresh rebuild from today's GIT (2e23685) and I can confirmed that the buttons are now shown whether I select manually the audio-engine to be JACK, or if the "auto" mode is choosing JACK as the audio engine.

Then, a second related bug is appearing: when "auto" is used (and choosing JACK by its own), if I click on one of those 2 buttons ("J.TRANS" or "J.MASTER", I've got a pop up window telling me that: "JACK-transport will work only with JACK driver".

Hope that helps.

mauser added a commit that referenced this issue Aug 17, 2016
@mauser
Bugfix for #392: Part 2...
cd9b7e1
@mauser
Copy link
Member

mauser commented Aug 17, 2016

Sorry, i forgot to modify the checks for the transport/master buttons. Please check again 😄

@trebmuh
Copy link
Member Author

trebmuh commented Aug 17, 2016 •
edited

Fresh rebuild from today's GIT (cd9b7e1) and I can confirmed that the pop-up window is not poping anymore.

I've checked with a 0.9.6.1 version (debian jessie repo) and this (unexpected/incorrect) behavior was already there, so I did put a line here https://github.com/hydrogen-music/hydrogen/wiki/New-features-in-Hydrogen-0.9.7#bugfixes

I'm closing this issue and removing the screencast then.
Thanks @mauser !

@trebmuh trebmuh closed this as completed Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mauser @trebmuh