Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt + P shortcut to the Preferences dialog is currently broken #393

Closed
trebmuh opened this issue Aug 9, 2016 · 4 comments
Closed

Alt + P shortcut to the Preferences dialog is currently broken #393

trebmuh opened this issue Aug 9, 2016 · 4 comments

Comments

@trebmuh
Copy link
Member

trebmuh commented Aug 9, 2016

When on Hydrogen main's window, if I'm trying to make the Preferences dialog to pop up using Alt + P, it does not work since Alt+P is opening the sub-menu "Project".

Edit: when running from a terminal, I've got this message appearing when doing a first Alt + P:

QAction::eventFilter: Ambiguous shortcut overload: Alt+P

The second Alt + P is opening the sub-menu "Project".

@mauser
Copy link
Member

mauser commented Aug 10, 2016

Hi!

Confirmed.

Since Alt+P seems to be quite common for "Preferences", i would like to stick with that. But this means that we have to change the short cut for the "Project" menu. Alt+J would be possible.

The downside is that the keyboard shortcut is related to the translation of the string: The string of the "Project" menu entry is "&Project", which is different from "Pro&ject". This means that this string has to be re-translated in all translations. I suspect that not all translations will be updated for 0.9.7, so in the end a lot of people will end up with an untranslated text for the Project menu. But i suppose that's the only reasonable solution at this point..

@trebmuh
Copy link
Member Author

trebmuh commented Aug 10, 2016

But i suppose that's the only reasonable solution at this point..

I suppose too since I can't find a solution allowing to workaround that. Maybe we could send an email to the different translators before releasing, asking for a special effort on this specific line of translation?

mauser added a commit that referenced this issue Aug 11, 2016
@mauser
Copy link
Member

mauser commented Aug 11, 2016

Should be fixed now..

@trebmuh
Copy link
Member Author

trebmuh commented Aug 11, 2016

Fresh rebuild from today's GIT (2e23685), and I'm confirming that it is fixed now.

Added to https://github.com/hydrogen-music/hydrogen/wiki/New-features-in-Hydrogen-0.9.7

I'm closing this issue now. Thanks for your celerity (again) !

@trebmuh trebmuh closed this as completed Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants