Sample selection #291
Sample selection #291
Conversation
Conflicts: src/core/include/hydrogen/basics/instrument.h src/core/src/basics/instrument.cpp src/core/src/basics/sample.cpp src/core/src/sampler/sampler.cpp
…nto sample_selection
…nto sample_selection Conflicts: data/img/gray/instrumentEditor/layerTabsupernew.png
…nto sample_selection
…nto sample_selection
…nto sample_selection
…nto sample_selection Conflicts: src/core/include/hydrogen/basics/song.h
…nto sample_selection
…nto sample_selection
|
@blablack I'm happy to help testing this. That said, this is a bit out of the way I'm using Hydrogen usually and I don't quite understand the workflow involved in. Would you mind to explain a bit deeper the intention? (which might be easier in french if you want) |
|
@trebmuh thanks for helping. |
|
@blablack: sweet, thanks for pointing me to the right direction. I'll be trying to have a look to this when I got a bit of time for testing and will keep you in touch. |
…nto sample_selection
| @@ -196,6 +196,7 @@ bool Sample::apply_loops( const Loops& lo ) | |||
| ERRORLOG( QString( "count %1 < 0 is not allowed" ).arg( lo.count ) ); | |||
| return false; | |||
| } | |||
| //if( lo == __loops ) return true; | |||
There was a problem hiding this comment.
No...well yes...but no...
The line was commented out anyway - but you removed it all together in
https://github.com/blablack/hydrogen/commit/5b20e0543aaa31d9814250796c339cd76c2d0dea
I looks like it didn't go through during a merge...
On Sat, Mar 26, 2016 at 11:29 AM Sebastian Moors notifications@github.com
wrote:
In src/core/src/basics/sample.cpp
#291 (comment)
:@@ -196,6 +196,7 @@ bool Sample::apply_loops( const Loops& lo )
ERRORLOG( QString( "count %1 < 0 is not allowed" ).arg( lo.count ) );
return false;
}
- //if( lo == __loops ) return true;
Is the comment intentional?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/hydrogen-music/hydrogen/pull/291/files/d9cf06ecea6c676553607db7cc76f72e376935a6#r57512542
…nto sample_selection
…nto sample_selection
|
@trebmuh any news on the testing? I would be really curious to know how others than me find the functionality. |
|
Hi!! About the new Graphic for the instrument tab: Could you save some height there? I feel bad for complaining here again about the height (as with the hihat group feature), but this is certainly an issue at the moment :-/ |
…nto sample_selection
|
@mauser I am not sure what I can do about the height here. Out of curiosity, why do you consider the height being an issue? |
|
Hi, attached is a preview of hydrogen on my laptop (1280x800). On the initial startup, i can't see the end of the current sample editor (main branch). If i want to view the old sample editor completely, i have to pull the lower part of hydrogen's view up to "Pattern 8" of the SongEditor (i hope that you understand what i mean :-/). If i use your branch with the new dropdown box, i have to pull the lower part up to "Pattern 6". And this is just with 800px screen height.. We had some requests coming from people who want to use hydrogen with screens that have a height of only 600px (mostly netbooks). As a consequence, we've tried to keep the minium screen height as low as possible. Hasn't really worked out on the sample tab, as you've already said :) There's also the "Tabbed interface mode" for such extreme situations, but that breaks usability a bit.. I've been tinkering a bit with this problem at the weekend and thought about re-designing the whole section on the right side. It would save some space if we create a tabbed panel with three tabs: instrument properties, sample/layer properties, soundlibrary browser. Maybe there could be also a fourth tab for advanced instrument settings (i'm think mostly about your midi additions and the midi out setting and the apply velocity property). This would also give us the possibility to some additional descriptions to the UI (at the moment is unclear what the channel/note properties are used for midi out, unless you're looking at the tooltips). Just to make it clear: I don't think that this has to be done in this pull request. If the situation can't be improved with the current layout, i have no problems with accepting this flaw and fixing it afterwards with a new layout of the whole section..
|
|
@mauser As far as I can tell, I can't really see an effective way to fix the current layout. I guess with all the changes in 0.9.7 there is effectively a need to modify the layout all together (similarly to a menu redesign as in #330). One other "easier" option is the bitwig way of making the whole right column go all the way up over the patterns... |
…nto sample_selection
|
Has anybody been able to use the functionality? |
…nto sample_selection
|
@mauser as the height issue cannot really be solved efficiently right now without a bigger redesign of Hydrogen, do you have any other objection to merge this pull request into the master branch? If you have any other feedback let me know! Thanks in advance, |
…nto sample_selection
|
Just looked again in the pull request (merging it now) and i'm, wondering why you commented the codeblock at src/gui/src/InstrumentEditor/LayerPreview.cpp:194 , or to be more precious: I'm wondering what the initial intention of the code was :) Can we remove that part? |
|
Hi @blablack: I didn't tried it yet (I'll soonish), but reading at https://github.com/hydrogen-music/hydrogen/issues/247 , I really love the intent! |
|
@blablack: by the way, do you know of a drumkit which include several samples for the same layer? It would then save me a drumkit construction. Edit: nevermind, I found my way in tweaking the layers in an existing one. |
|
OK, tried it and I've got to say that this new feature is more than awesome! I really love it, thanks for this! Kudos! |
|
now all we need are drumkits with multiple samples ! |
|
👍 |
|
For a multiple-samples drumkit, we can use SMMDrums : https://smmdrums.wordpress.com/ |
|
@LemarinelNet : seems like an awsome source for samples ! |
This pull requests enables samples to be selected differently in addition to the usual velocity based: