You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fetching data in csv format is implemented in get_ticker_price but not get_dataframe.
I've made the changes on my end adding a fmt paramerter to get_dataframe which can be set to csv. If you like, I'm happy to put together a pull request with these changes.
What I Did
N/A
The text was updated successfully, but these errors were encountered:
I didn't know about that performance difference- that's terrific to know! I would be very glad to see this capability added to the library, thank you for reaching out. Your proposed solution sounds good + consistent with the design of other parts of the library.
Hi @hydrosquall, I've submitted the pull request and everything looks good so far. I noticed my vcrpy fixtures look different than the ones in the repo. Not sure why that is.
Description
Hi, I noticed in the tiingo docs they mention that a csv response is 4-5x faster than json (https://api.tiingo.com/documentation/general/overview -- 1.1.4 Response Formats).
Fetching data in csv format is implemented in
get_ticker_price
but notget_dataframe
.I've made the changes on my end adding a
fmt
paramerter toget_dataframe
which can be set tocsv
. If you like, I'm happy to put together a pull request with these changes.What I Did
N/A
The text was updated successfully, but these errors were encountered: