Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints for public APIs #49

Merged
merged 5 commits into from
Jan 26, 2023
Merged

Add type hints for public APIs #49

merged 5 commits into from
Jan 26, 2023

Conversation

hynek
Copy link
Owner

@hynek hynek commented Jan 25, 2023

I'm too busy lazy to add stubs for everything, but this should work for most people without resorting to Mypy plugins etc?

@playpauseandstop
Copy link
Contributor

Only advice I can give is covering environ.bool_var(...) call within typing_examples module. Beside that all looks great! Thanks a lot for your time

@hynek
Copy link
Owner Author

hynek commented Jan 26, 2023

Yeah thanks! And ugh, I forgot about the whole secrets module, too.

@hynek hynek merged commit 683b129 into main Jan 26, 2023
@hynek hynek deleted the stubs branch January 26, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants