Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't codegen meshes #453

Merged
merged 1 commit into from
Nov 19, 2020
Merged

don't codegen meshes #453

merged 1 commit into from
Nov 19, 2020

Conversation

andrewheumann
Copy link
Member

@andrewheumann andrewheumann commented Nov 18, 2020 •
edited
Loading

BACKGROUND:

  • The inclusion of Mesh in the "known types" broke the use of input meshes.

DESCRIPTION:

  • Removes mesh-related "known types"

FUTURE WORK:

  • We should consolidate our mesh types!

This change is Reviewable

wynged
wynged approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@andrewheumann andrewheumann merged commit c6aa365 into master Nov 19, 2020
@andrewheumann andrewheumann deleted the dont-codegen-meshes branch November 19, 2020 20:08
@andrewheumann andrewheumann mentioned this pull request Nov 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wynged wynged wynged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheumann @wynged