Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCP support (take 2) #42

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

TCP support (take 2) #42

wants to merge 50 commits into from

Commits on Nov 23, 2019

  1. add NetworkProtocol, Client.networkProtocol that defaults to UDP

    @daveyarwood
    daveyarwood committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    6978b4b View commit details
    Browse the repository at this point in the history

  2. add Server.networkProtocol, NewServer constructor that defaults netwo… 

    …rkProtocol to UDP
    @daveyarwood
    daveyarwood committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    1797219 View commit details
    Browse the repository at this point in the history

  3. WIP send/receive test; implement receiving TCP packet on the server side

    @daveyarwood
    daveyarwood committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    1af7230 View commit details
    Browse the repository at this point in the history

  4. test sending and receiving a packet too large for UDP

    @daveyarwood
    daveyarwood committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    f7cf869 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2019

  1. fix test so that it propagates client send errors

    @daveyarwood
    daveyarwood committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    ccb4667 View commit details
    Browse the repository at this point in the history

  2. for TCP, use ioutil.ReadAll, since we don't know the packet size and … 

    …it could be > 65535
    @daveyarwood
    daveyarwood committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    ce6b523 View commit details
    Browse the repository at this point in the history

  3. improve/fix NewClient and NewServer docstrings

    @daveyarwood
    daveyarwood committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    d3abe21 View commit details
    Browse the repository at this point in the history

  4. add client.laddrTCP; adjust SetLocalAddr to set laddrTCP when the pro… 

    …tocol is TCP
    @daveyarwood
    daveyarwood committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    bdf2feb View commit details
    Browse the repository at this point in the history

  5. fix/improve test error message

    @daveyarwood
    daveyarwood committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    f79e90b View commit details
    Browse the repository at this point in the history

  6. document why the UDP test only sends a string of length 500

    @daveyarwood
    daveyarwood committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    0f5a2db View commit details
    Browse the repository at this point in the history

  7. use a 1,000,000 byte string for the TCP test

    @daveyarwood
    daveyarwood committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    a1a5612 View commit details
    Browse the repository at this point in the history

  8. implement TCP sending on the client side

    @daveyarwood
    daveyarwood committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    cad5813 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2019

  1. document use of TCP

    @daveyarwood
    daveyarwood committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    750795b View commit details
    Browse the repository at this point in the history

  2. mention TCP support in README

    @daveyarwood
    daveyarwood committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    1e1356a View commit details
    Browse the repository at this point in the history

  3. use port instead of hard-coded 6677 in one place I missed

    @daveyarwood
    daveyarwood committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    e255750 View commit details
    Browse the repository at this point in the history

  4. refactor TestServerMessageDispatching in order to test TCP; handle er… 

    …rors from server.Serve
    @daveyarwood
    daveyarwood committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    760ff36 View commit details
    Browse the repository at this point in the history

  5. tests should propagate errors immediately instead of logging them and… 

    … attempting to continue
    @daveyarwood
    daveyarwood committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    d0cdbed View commit details
    Browse the repository at this point in the history

  6. implement server.ServeTCP; augment & refactor tests a bit

    @daveyarwood
    daveyarwood committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    baf2e0b View commit details
    Browse the repository at this point in the history

  7. add mechanism for closing server connection; refactor test code to us… 

    …e server.ListenAndServe and server.CloseConnection
    @daveyarwood
    daveyarwood committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    0589c1e View commit details
    Browse the repository at this point in the history

  8. ensure that ListenAndServe closes its connection when done

    @daveyarwood
    daveyarwood committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    1e0bc13 View commit details
    Browse the repository at this point in the history

  9. make CloseConnection idempotent / nil-safe

    @daveyarwood
    daveyarwood committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    a9950d0 View commit details
    Browse the repository at this point in the history

  10. implement TCP in ListenAndServe

    @daveyarwood
    daveyarwood committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    2bd0f80 View commit details
    Browse the repository at this point in the history

  11. use a 1,000,000 byte string for the TCP test

    @daveyarwood
    daveyarwood committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    7e38197 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2019

  1. Merge remote-tracking branch 'origin/master' into tcp-support

    @daveyarwood
    daveyarwood committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    cbf35e4 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2020

  1. adjust examples/client/client.go to generate random packets with nest… 

    …ed bundles and args of various types
    @daveyarwood
    daveyarwood committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    f18edda View commit details
    Browse the repository at this point in the history

  2. fix typo

    @daveyarwood
    daveyarwood committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    8973d7b View commit details
    Browse the repository at this point in the history

  3. adjust dispatching_server to allow setting the network protocol

    @daveyarwood
    daveyarwood committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    90bad45 View commit details
    Browse the repository at this point in the history

  4. implement String() on NetworkProtocol

    @daveyarwood
    daveyarwood committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    9bd7cb2 View commit details
    Browse the repository at this point in the history

  5. support reading 'N' (null) arguments

    @daveyarwood
    daveyarwood committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    7d349fa View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2020

  1. fix references to Timetag that should be *Timetag 

    When Timetag arguments are read from incoming messages, they are parsed as
*Timetag, so these references to Timetag needed to be adjusted accordingly.
    @daveyarwood
    daveyarwood committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    64360b3 View commit details
    Browse the repository at this point in the history

  2. basic_server updates: support setting protocol; print nested packets 

    example output:

-- OSC Bundle (2020-01-12 08:42:13.430108205 -0500 EST):
  -- OSC Message hypebeast#1: /bundle/message/1 ,Tsb true test string 956 blob
  -- OSC Message hypebeast#2: /bundle/message/3 ,Ni Nil 70030
  -- OSC Bundle (2020-01-12 08:42:13.430141439 -0500 EST):
    -- OSC Message hypebeast#1: /bundle/message/2 ,s test string 353
    -- OSC Message hypebeast#2: /bundle/message/3 ,iTb 24665 true blob
    -- OSC Bundle (2020-01-12 08:42:13.430142487 -0500 EST):
      -- OSC Message hypebeast#1: /bundle/message/2 ,FN false Nil
      -- OSC Bundle (2020-01-12 08:42:13.430143456 -0500 EST):
        -- OSC Bundle (2020-01-12 08:42:13.430144334 -0500 EST):
          -- OSC Message hypebeast#1: /bundle/message/1 ,si test string 370 18937
          -- OSC Message hypebeast#2: /bundle/message/2 ,Ts true test string 275
          -- OSC Bundle (2020-01-12 08:42:13.430158528 -0500 EST):
            -- OSC Message hypebeast#1: /bundle/message/1 ,TiT true 11536 true
            -- OSC Bundle (2020-01-12 08:42:13.430168011 -0500 EST):
              -- OSC Message hypebeast#1: /bundle/message/1 ,iF 53026 false
              -- OSC Message hypebeast#2: /bundle/message/2 ,bi blob 91772
              -- OSC Message hypebeast#3: /bundle/message/3 ,N Nil
              -- OSC Message hypebeast#4: /bundle/message/4 ,T true
    @daveyarwood
    daveyarwood committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    87688fa View commit details
    Browse the repository at this point in the history

  3. bugfix: correctly handle padding 0-bytes at the end of a packet

    @daveyarwood
    daveyarwood committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    b645a08 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2020

  1. Revert "bugfix: correctly handle padding 0-bytes at the end of a packet" 

    This reverts commit b645a08.

It turns out that when I was testing with a JavaOSC client, there was a
bug in the client causing additional 0 bytes to be added to the end.
This is actually incorrect. What we had before was correct.
    @daveyarwood
    daveyarwood committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    3d015df View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2020

  1. Merge branch 'master' into tcp-support

    @daveyarwood
    daveyarwood committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    7b957ff View commit details
    Browse the repository at this point in the history

  2. fix inadvertent syntax error

    @daveyarwood
    daveyarwood committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    c60efee View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Use functional options for protocol selection

    @glynternet
    glynternet committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    3525c23 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2020

  1. pass error through as the return value of s.CloseConnection

    @daveyarwood
    daveyarwood committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    0d5fecc View commit details
    Browse the repository at this point in the history

  2. rename Option => ServerOption in preparation for ClientOption

    @daveyarwood
    daveyarwood committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    7d5ed2e View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2020

  1. collapse private UDP/TCP receive packet functions into the implementa… 

    …tion of the public functions; add doc comments
    @daveyarwood
    daveyarwood committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    ee682ad View commit details
    Browse the repository at this point in the history

  2. fix doc references to osc.WithProtocol

    @daveyarwood
    daveyarwood committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    d63ce05 View commit details
    Browse the repository at this point in the history

  3. add doc comment for *server.Serve

    @daveyarwood
    daveyarwood committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    dbf3c45 View commit details
    Browse the repository at this point in the history

  4. rename WithProtocol => ServerProtocol in preparation for ClientProtocol

    @daveyarwood
    daveyarwood committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    4d54797 View commit details
    Browse the repository at this point in the history

  5. be consistent about not prefixing funcs in doc comments with "osc."

    @daveyarwood
    daveyarwood committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    4e71bc3 View commit details
    Browse the repository at this point in the history

  6. refactor client using functional options

    @daveyarwood
    daveyarwood committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    0675d0a View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Merge branch 'randomized-string-tests' into tcp-support-2

    @daveyarwood
    daveyarwood committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    24f2d85 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'tcp-support' into tcp-support-2

    @daveyarwood
    daveyarwood committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    9da33ad View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. Fix the number of arguments expected by the server and client demos 

    On my subsequent branch that adds TCP, I added a second argument that is
the protocol to use. That's why these scripts currently expect 2
arguments. However, on _this_ branch, only the first argument is used,
and that first argument is the port. I ended up b0rking this when I
extracted this branch from the rest to make PR review easier.

This commit fixes it so that the scripts expect the correct number of
arguments, which is 1 argument, the port.
    @daveyarwood
    daveyarwood committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    93478a0 View commit details
    Browse the repository at this point in the history

  2. Fix the number of arguments expected by the client and server examples 

    Now, these examples expect 2 arguments: the protocol and the port.
    @daveyarwood
    daveyarwood committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    b69b5ee View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2021

  1. Merge branch 'randomized-string-tests' into tcp-support-2

    @daveyarwood
    daveyarwood committed Aug 15, 2021
    Configuration menu
    Copy the full SHA
    017ebb1 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2023

  1. Merge branch 'master' into tcp-support-2

    @daveyarwood
    daveyarwood committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    11a612f View commit details
    Browse the repository at this point in the history