feat: Duplicate chart #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a767ad9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
svc-shorpo
force-pushed
the
duplicate-chart
branch
2 times, most recently
from
0867926
to
ceae882
Compare
svc-shorpo
force-pushed
the
duplicate-chart
branch
from
ceae882
to
a767ad9
Compare
MikeShi42
approved these changes
Nov 17, 2023
| @@ -31,6 +31,7 @@ | |||
| "esbuild": "^0.14.47", | |||
| "fuse.js": "^6.6.2", | |||
| "immer": "^9.0.21", | |||
| "jotai": "^2.5.1", | |||
There was a problem hiding this comment.
ah it finally made its way into the project... @joelseq I think you'll enjoy this 😂
| }, [confirm, setConfirm]); | ||
|
|
||
| return confirm ? ( | ||
| <Modal show onHide={handleClose}> |
There was a problem hiding this comment.
Personally I'd prefer a tooltip next to the action button but can see how this is faster to implement rn
|
|
||
| return React.useCallback( | ||
| async (message: string, confirmLabel?: string): Promise<boolean> => { | ||
| return new Promise(resolve => { |
There was a problem hiding this comment.
new pattern learned for me today 🤯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker compose -f docker-compose.dev.yml up -d --no-deps --build appafter pulling this branchScreen.Recording.2023-11-16.at.7.19.24.PM.mov