feat: Duplicate chart #109
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@hyperdx/app': minor | ||
| --- | ||
|
|
||
| feat: Add dashboard delete confirmations and duplicate chart button |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| import * as React from 'react'; | ||
| import { atom, useAtomValue, useSetAtom } from 'jotai'; | ||
| import Modal from 'react-bootstrap/Modal'; | ||
| import Button from 'react-bootstrap/Button'; | ||
|
|
||
| type ConfirmAtom = { | ||
| message: string; | ||
| confirmLabel?: string; | ||
| onConfirm: () => void; | ||
| onClose?: () => void; | ||
| } | null; | ||
|
|
||
| const confirmAtom = atom<ConfirmAtom>(null); | ||
|
|
||
| export const useConfirm = () => { | ||
| const setConfirm = useSetAtom(confirmAtom); | ||
|
|
||
| return React.useCallback( | ||
| async (message: string, confirmLabel?: string): Promise<boolean> => { | ||
| return new Promise(resolve => { | ||
|
There was a problem hiding this comment. new pattern learned for me today 🤯 |
||
| setConfirm({ | ||
| message, | ||
| confirmLabel, | ||
| onConfirm: () => { | ||
| resolve(true); | ||
| setConfirm(null); | ||
| }, | ||
| onClose: () => { | ||
| resolve(false); | ||
| setConfirm(null); | ||
| }, | ||
| }); | ||
| }); | ||
| }, | ||
| [setConfirm], | ||
| ); | ||
| }; | ||
|
|
||
| export const useConfirmModal = () => { | ||
| const confirm = useAtomValue(confirmAtom); | ||
| const setConfirm = useSetAtom(confirmAtom); | ||
|
|
||
| const handleClose = React.useCallback(() => { | ||
| confirm?.onClose?.(); | ||
| setConfirm(null); | ||
| }, [confirm, setConfirm]); | ||
|
|
||
| return confirm ? ( | ||
| <Modal show onHide={handleClose}> | ||
|
There was a problem hiding this comment. Personally I'd prefer a tooltip next to the action button but can see how this is faster to implement rn |
||
| <Modal.Body className="bg-hdx-dark"> | ||
| {confirm.message} | ||
| <div className="mt-3 d-flex justify-content-end gap-2"> | ||
| <Button variant="secondary" onClick={handleClose} size="sm"> | ||
| Cancel | ||
| </Button> | ||
| <Button variant="success" onClick={confirm.onConfirm} size="sm"> | ||
| {confirm.confirmLabel || 'OK'} | ||
| </Button> | ||
| </div> | ||
| </Modal.Body> | ||
| </Modal> | ||
| ) : null; | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah it finally made its way into the project... @joelseq I think you'll enjoy this 😂