feat: New metrics name select #331

svc-shorpo · 2024-03-02T23:02:14Z

Screen.Recording.2024-03-02.at.11.00.51.PM.mov

	🚀 This PR description was created by Ellipsis for commit `d4a8491`.

Summary:

This PR enhances the user interface and functionality by updating the MetricNameSelect function to use MSelect and modifying the Drawer and Button components.

Key points:

Enhances the user interface and functionality of the application
Updates the MetricNameSelect function in ChartUtils.tsx to use MSelect instead of AsyncSelect
Modifies the Drawer and Button components in SessionSidePanel.tsx

Generated with ❤️ by ellipsis.dev

changeset-bot · 2024-03-02T23:02:17Z

⚠️ No Changeset found

Latest commit: a4d799b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ellipsis-dev

❌ Changes requested.

Reviewed the entire pull request up to 2fe32cc
Looked at 110 lines of code in 2 files
Took 1 minute and 9 seconds to review

More info

Skipped 0 files when reviewing.
Skipped posting 0 additional comments because they didn't meet confidence threshold of 50%.

Workflow ID: wflow_r3CjoCBArY3muBhE

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.

ellipsis-dev · 2024-03-02T23:03:33Z

packages/app/src/ChartUtils.tsx

+    />
+  );
+
+  return (


The AsyncSelect component is still being returned at the end of the MetricNameSelect function. This seems redundant as the MSelect component is already being returned earlier in the function. Consider removing this redundant return statement.

ellipsis-dev

❌ Changes requested.

Performed an incremental review on 86be50c
Looked at 74 lines of code in 1 files
Took 1 minute and 36 seconds to review

More info

Skipped 0 files when reviewing.
Skipped posting 0 additional comments because they didn't meet confidence threshold of 50%.

Workflow ID: wflow_lmDl4EesNni31T7I

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.

ellipsis-dev · 2024-03-02T23:07:13Z

packages/app/src/ChartUtils.tsx

@@ -2,7 +2,13 @@ import { useMemo, useRef, useState } from 'react';
 import { add } from 'date-fns';
 import Select from 'react-select';
 import AsyncSelect from 'react-select/async';


This import of AsyncSelect is no longer used and should be removed to keep the code clean.

ellipsis-dev · 2024-03-02T23:07:13Z

packages/app/src/ChartUtils.tsx

@@ -441,6 +447,7 @@
    </>
  );
 }
+import { Autocomplete } from '@mantine/core';


This import of Autocomplete is not used and should be removed to keep the code clean.

ellipsis-dev · 2024-03-02T23:07:13Z

packages/app/src/ChartUtils.tsx

-    <AsyncSelect
-      isLoading={isLoading}
-      isDisabled={isError}
+    <MSelect


The MSelect component should include a similar filtering functionality to the loadOptions prop of the AsyncSelect component it replaced. This will prevent potential performance issues if the options list is very large.

ellipsis-dev

👍 Looks good to me!

Performed an incremental review on d4a8491
Looked at 66 lines of code in 1 files
Took 1 minute and 26 seconds to review

More info

Skipped 0 files when reviewing.
Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.

1. /packages/app/src/ChartUtils.tsx:474:

Assessed confidence : 80%
Grade: 0%
Comment:
The AsyncSelect component was replaced with MSelect. The AsyncSelect component was used to load options asynchronously, but the new MSelect component does not have this functionality. This could potentially lead to performance issues if there are a large number of options to load.
Reasoning:
The PR changes the AsyncSelect component to MSelect from mantine. The AsyncSelect component was used to load options asynchronously, but the new MSelect component does not have this functionality. This could potentially lead to performance issues if there are a large number of options to load.

Workflow ID: wflow_KEnV5aWKX2eJlX69

Not what you expected? You can customize the content of the reviews using rules. Learn more here.

MikeShi42 · 2024-03-03T05:38:36Z

nice! i'm wondering if this was tested against how it performs on a few thousand or 10k items? iirc this was an easy component to overwhelm

svc-shorpo · 2024-03-03T10:14:49Z

nice! i'm wondering if this was tested against how it performs on a few thousand or 10k items? iirc this was an easy component to overwhelm

yes, just tested it with 10k items, works smooth. I set a limit to render only 100 items max at a time so it shouldn't overwhelm

Screen.Recording.2024-03-03.at.10.12.08.AM.mov

https://github.com/hyperdxio/hyperdx/assets/149748269/2023c7d3-be2e-400d-be88-6f31e2f59f1d ---- | <a href="https://ellipsis.dev" target="_blank"><img src="https://avatars.githubusercontent.com/u/80834858?s=400&u=31e596315b0d8f7465b3ee670f25cea677299c96&v=4" alt="Ellipsis" width="30px" height="30px"/></a> | 🚀 This PR description was created by [Ellipsis](https://www.ellipsis.dev) for commit d4a8491. | |--------|--------| ### Summary: This PR enhances the user interface and functionality by updating the `MetricNameSelect` function to use `MSelect` and modifying the `Drawer` and `Button` components. **Key points**: - Enhances the user interface and functionality of the application - Updates the `MetricNameSelect` function in `ChartUtils.tsx` to use `MSelect` instead of `AsyncSelect` - Modifies the `Drawer` and `Button` components in `SessionSidePanel.tsx` ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev)

ellipsis-dev bot reviewed Mar 2, 2024

View reviewed changes

svc-shorpo force-pushed the sr/hdx-500-2 branch from 2fe32cc to 86be50c Compare March 2, 2024 23:05

ellipsis-dev bot reviewed Mar 2, 2024

View reviewed changes

feat: New metrics name select

d4a8491

svc-shorpo force-pushed the sr/hdx-500-2 branch from 86be50c to d4a8491 Compare March 2, 2024 23:17

ellipsis-dev bot reviewed Mar 2, 2024

View reviewed changes

MikeShi42 approved these changes Mar 3, 2024

View reviewed changes

svc-shorpo added the automerge label Mar 3, 2024

Merge branch 'main' into sr/hdx-500-2

a4d799b

kodiakhq bot merged commit b21eada into main Mar 3, 2024
4 checks passed

kodiakhq bot deleted the sr/hdx-500-2 branch March 3, 2024 20:37

svc-shorpo mentioned this pull request Mar 3, 2024

fix: Fix empty state for HDXSpanPerformanceBarChart #333

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: New metrics name select #331

feat: New metrics name select #331

svc-shorpo commented Mar 2, 2024 •

edited by ellipsis-dev bot

changeset-bot bot commented Mar 2, 2024 •

edited

ellipsis-dev bot left a comment

ellipsis-dev bot Mar 2, 2024

ellipsis-dev bot left a comment

ellipsis-dev bot Mar 2, 2024

ellipsis-dev bot Mar 2, 2024

ellipsis-dev bot Mar 2, 2024

ellipsis-dev bot left a comment

MikeShi42 commented Mar 3, 2024

svc-shorpo commented Mar 3, 2024 •

edited

feat: New metrics name select #331

feat: New metrics name select #331

Conversation

svc-shorpo commented Mar 2, 2024 • edited by ellipsis-dev bot

Summary:

changeset-bot bot commented Mar 2, 2024 • edited

⚠️ No Changeset found

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

ellipsis-dev bot Mar 2, 2024

Choose a reason for hiding this comment

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

ellipsis-dev bot Mar 2, 2024

Choose a reason for hiding this comment

ellipsis-dev bot Mar 2, 2024

Choose a reason for hiding this comment

ellipsis-dev bot Mar 2, 2024

Choose a reason for hiding this comment

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

MikeShi42 commented Mar 3, 2024

svc-shorpo commented Mar 3, 2024 • edited

svc-shorpo commented Mar 2, 2024 •

edited by ellipsis-dev bot

changeset-bot bot commented Mar 2, 2024 •

edited

svc-shorpo commented Mar 3, 2024 •

edited