fix: Fix empty state for HDXSpanPerformanceBarChart

[svc-shorpo]

---

	🚀 This PR description was created by Ellipsis for commit 22eff91.

Summary:

This PR improves the handling of empty states in the HDXSpanPerformanceBarChart component, including changes to text color and the condition and message for the 'No data' state.

Key points:

• Modifies HDXSpanPerformanceBarChart component to improve handling of empty states.
• Updates text color for loading, error, and no data messages from text-muted to text-slate-400.
• Changes the condition for displaying the 'No data' message to check for the absence of rows.
• Updates the 'No data' message to 'No children spans recorded for this route'.

---

Generated with ❤️ by ellipsis.dev

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2186b8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ellipsis-dev]

👍 Looks good to me!

• Reviewed the entire pull request up to 2186b8c
• Looked at 27 lines of code in 1 files
• Took 29 seconds to review

More info

• Skipped 0 files when reviewing.
• Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.

1. /packages/app/src/HDXListBarChart.tsx:267:

• Assessed confidence : 50%
• Comment:
  The condition for displaying the 'no data' message has been changed from 'data?.data?.length === 0' to 'rows?.length === 0'. Please ensure that 'rows' and 'data?.data' are equivalent, otherwise this could introduce a logical bug.
• Reasoning:
  The PR changes the text color for loading, error, and no data messages from 'text-muted' to 'text-slate-400'. This seems to be a simple styling change and doesn't appear to introduce any bugs. However, the PR also changes the condition for displaying the 'no data' message from 'data?.data?.length === 0' to 'rows?.length === 0'. This could potentially introduce a logical bug if 'rows' and 'data?.data' are not equivalent. I need to check the codebase to confirm whether this change is correct.

Workflow ID: wflow_ad8OEMOjucmSNkcz

---

Not what you expected? You can customize the content of the reviews using rules. Learn more here.

[ellipsis-dev]

👍 Looks good to me!

• Performed an incremental review on 22eff91
• Looked at 26 lines of code in 1 files
• Took 55 seconds to review

More info

• Skipped 0 files when reviewing.
• Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.

1. /packages/app/src/HDXListBarChart.tsx:259:

• Assessed confidence : 50%
• Comment:
  The color change from 'text-muted' to 'text-slate-400' seems fine as it's likely a stylistic choice. However, the change in the condition for displaying the no data message from 'data?.data?.length === 0' to 'rows?.length === 0' could potentially introduce a logical bug if 'rows' and 'data?.data' are not guaranteed to be equivalent. Please ensure that this change is intended and that 'rows' and 'data?.data' are indeed equivalent in this context.
• Reasoning:
  The PR changes the color of the loading, error, and no data messages from 'text-muted' to 'text-slate-400'. It also changes the condition for displaying the no data message from 'data?.data?.length === 0' to 'rows?.length === 0'. The PR does not seem to introduce any logical, performance, or security bugs. However, it's not clear from the PR description why these changes were made. I'll check the codebase to see if there's any context that might explain these changes.

Workflow ID: wflow_lT3kJDxFPatHpL2p

---

Not what you expected? You can customize the content of the reviews using rules. Learn more here.