Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider providing constants for keep-alive and proxy-connection header names. #142

Open
carllerche opened this issue Nov 14, 2017 · 4 comments
Labels
A-headers Area: HTTP headers B-rfc Blocked: request for comments. More discussion would help move this along. S-feature Severity: feature. This adds something new.

Comments

@carllerche
Copy link
Collaborator

The HTTP/2.0 spec requires implementations to verify that these headers do not get included in outbound messages, and thus must check for them.

Providing constants would help speed up these checks.

@seanmonstar
Copy link
Member

seanmonstar commented Nov 14, 2017

I had this exact thought while writing that PR, but also this conflicting thought: both are non-standard headers that we (HTTP in general) want to go away.

Could we add them but make them doc hidden or something?

@carllerche
Copy link
Collaborator Author

Doc hidden is fine.

@carllerche
Copy link
Collaborator Author

Also, those constants can be deprecated once const fn happens.

@seanmonstar
Copy link
Member

I don't think we could use const fn here, since we have to validate the bytes. A procedural macro could eventually exist to compile-time check/create header names...

@seanmonstar seanmonstar added S-feature Severity: feature. This adds something new. B-rfc Blocked: request for comments. More discussion would help move this along. A-headers Area: HTTP headers labels Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-headers Area: HTTP headers B-rfc Blocked: request for comments. More discussion would help move this along. S-feature Severity: feature. This adds something new.
Projects
None yet
Development

No branches or pull requests

2 participants