Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give the opportunity to comment #70

Closed
carllerche opened this issue Jul 29, 2017 · 2 comments
Closed

Give the opportunity to comment #70

carllerche opened this issue Jul 29, 2017 · 2 comments
Milestone
0.1

Comments

@carllerche
Copy link
Collaborator

I saw #67 merged before there was an opportunity given to comment. I'm opening this issue as a placeholder to review.
@carllerche carllerche added this to the 0.1 milestone Jul 29, 2017
@alexcrichton
Copy link
Contributor

Sorry I assumed we just wanted a reviewer, but if we want to require multiple reviewers we can. Plus changes like #67 are API backwards-compatible to revert?

@carllerche
Copy link
Collaborator Author

I made #85 to reflect the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
2 participants
@carllerche @alexcrichton