Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDS example does not build on Windows #205

Closed
repi opened this issue Dec 22, 2019 · 6 comments
Closed

UDS example does not build on Windows #205

repi opened this issue Dec 22, 2019 · 6 comments

Comments

@repi
Copy link
Contributor

repi commented Dec 22, 2019

Find a Windows equivalent of the below or try and disable the example on Windows?

error[E0432]: unresolved import `tokio::net::UnixStream`
  --> examples\src/uds/client.rs:10:5
   |
10 | use tokio::net::UnixStream;
   |     ^^^^^^^^^^^^^^^^^^^^^^ no `UnixStream` in `net`

error[E0432]: unresolved import `tokio::net::UnixListener`
 --> examples\src/uds/server.rs:9:5
  |
9 |     net::UnixListener,
  |     ^^^^^------------
  |     |    |
  |     |    help: a similar name exists in the module: `TcpListener`
  |     no `UnixListener` in `net`
@LucioFranco
Copy link
Member

We should just feature gate it, since I do not know of a similar thing for mio and windows. https://docs.rs/mio-uds/0.6.7/src/mio_uds/lib.rs.html#3

@messense
Copy link

@alce
Copy link
Collaborator

alce commented Jan 8, 2020

@messense crate looks good, unfortunately it has some outdated deps that overlap with Tonic's and I don't think it'll be worth the hassle, what do you think?

If you all agree I can try to figure out how to hide it from Windows

@messense
Copy link

messense commented Jan 8, 2020

I think hiding it from Windows is fine.

@alce
Copy link
Collaborator

alce commented Jan 12, 2020

I guess this was resolved on #206.

@LucioFranco can we close this?

@LucioFranco
Copy link
Member

Yes! thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants