Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Prost 0.7.0 #517

Closed
wchargin opened this issue Dec 29, 2020 · 2 comments
Closed

Support Prost 0.7.0 #517

wchargin opened this issue Dec 29, 2020 · 2 comments

Comments

@wchargin
Copy link

Feature Request

Upgrade to support Prost 0.7.0.

Crates

All.

Motivation

Prost 0.7.0 is now out. It includes general improvements, like
support for zero-copy deserialization of bytes fields, as well as
improvements of specific interest to Tonic, like support for file
descriptor sets to support gRPC reflection.

Applications that use Tonic cannot easily upgrade Prost until Tonic
itself is updated. (When I try to make the obvious change in my
downstream project, I get a slew of trait bound errors because of the
duplicate versions of prost::message::Message.)

Prost 0.7.0 depends on bytes = "1", so this may be blocked on
upgrading to v1 of the Tokio ecosystem.

@djc
Copy link
Contributor

djc commented Jan 12, 2021

This was done, as part of #530.

@wchargin
Copy link
Author

Sweet! Thanks @djc for the heads up and thanks to everyone on #530,
#514, and related work for the quick implementation here.

Looks like releasing is probably covered by #443, so I’ll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants