Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update warp UI to use multi-protocol utils/sdk #2652

Closed
jmrossy opened this issue Aug 13, 2023 · 3 comments · Fixed by hyperlane-xyz/hyperlane-warp-ui-template#56
Closed

Update warp UI to use multi-protocol utils/sdk #2652

jmrossy opened this issue Aug 13, 2023 · 3 comments · Fixed by hyperlane-xyz/hyperlane-warp-ui-template#56
Assignees
@jmrossy
Labels
tech-debt warp-route

Comments

@jmrossy
Copy link
Contributor

jmrossy commented Aug 13, 2023 •
edited
Loading

The Warp UI + utils/sdk packages have a bunch of duplicated logic that was added for sealevel kathy.
Migrate the warp UI to the new multi-protocol tooling
@jmrossy jmrossy self-assigned this Aug 13, 2023
@jmrossy jmrossy mentioned this issue Aug 13, 2023
Closed
@aroralanuk aroralanuk mentioned this issue Aug 24, 2023
Merged
@avious00
Copy link
Contributor

@jmrossy hey, does this issue still fit into this sprint? i see kunal has a related PR

@avious00
Copy link
Contributor

blocks #2651

@avious00 avious00 mentioned this issue Aug 31, 2023
Closed
@jmrossy
Copy link
Contributor Author

jmrossy commented Aug 31, 2023

@jmrossy hey, does this issue still fit into this sprint? i see kunal has a related PR

Hey, no it won't fit because more high-pri work has been brought in instead and also this must wait until we publish a fresh set of utils+sdk packages, which is semi-blocked by #2559

jmrossy added a commit that referenced this issue Sep 4, 2023
@aroralanuk @jmrossy
Migrate SealevelTokenAdapter from warp-routes-UI (#2684)
86f2731 
### Description

- Migrating `SealevelTokenAdapter` to monorepo for providing a common abstraction
- Common serialization code under `sdk/sealevel`

### Related issues

- #2652 

### Backward compatibility

Yes

### Testing

Manual

---------

Co-authored-by: J M Rossy <jm.rossy@gmail.com>
This was referenced Sep 6, 2023
Merged
Merged
jmrossy added a commit that referenced this issue Sep 13, 2023
@jmrossy @yorhodes
Finish migrating warp UI utils + adapters to SDK (#2711)
7a5dce2 
### Description

- Build on #2684, migrates the EvmAdapter and missing utils from the warp UI
- Remove the token App as it's unused and redundant with adapters
- Add IGP serialization code for #2546 
- Simplify multi-protocol adapters in SDK
- Make token adapters extend base adapters
- Move token serialization code to token package

### Drive-by changes

- Update Sepolia RPC which was causing errors

### Related issues

#2652 

### Backward compatibility

Yes

### Testing

Tested these in warp UI

---------

Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>
jmrossy added a commit to hyperlane-xyz/hyperlane-warp-ui-template that referenced this issue Sep 13, 2023
@jmrossy
Merge pull request #56 from hyperlane-xyz/sdk-1.5-dedupe
729abcf 
- Removes duplicated code with SDK/Token/Utils packages
- Upgrades Typescript for Viem type fix
- Adds experimental support for Sealevel IGPs

Fixes hyperlane-xyz/hyperlane-monorepo#2652
Related: hyperlane-xyz/hyperlane-monorepo#2711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmrossy jmrossy

Labels
tech-debt warp-route
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

De-dupe utils and adapter code with SDK and add IGP support hyperlane-xyz/hyperlane-warp-ui-template
2 participants
@jmrossy @avious00