Finish migrating warp UI utils + adapters to SDK #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrossy
commented
Sep 6, 2023
jmrossy
commented
Sep 6, 2023
jmrossy
commented
Sep 6, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2711 +/- ##
=======================================
Coverage 64.16% 64.16%
=======================================
Files 92 92
Lines 1398 1398
Branches 186 186
=======================================
Hits 897 897
Misses 494 494
Partials 7 7 ☔ View full report in Codecov by Sentry. |
jmrossy
commented
Sep 7, 2023
jmrossy
force-pushed
the
rossy/finish-warp-ui-migration
branch
from
1974859
to
86a65e0
Compare
Make token adapters extend base adapters Start adding IGP key handling to SealevelTokenAdapter
Finish IGP impl for SealevelTokenAdapter
yorhodes
approved these changes
Sep 12, 2023
Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>
Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>
Address other PR feedback
jmrossy
added a commit
to hyperlane-xyz/hyperlane-warp-ui-template
that referenced
this pull request
Sep 13, 2023
- Removes duplicated code with SDK/Token/Utils packages - Upgrades Typescript for Viem type fix - Adds experimental support for Sealevel IGPs Fixes hyperlane-xyz/hyperlane-monorepo#2652 Related: hyperlane-xyz/hyperlane-monorepo#2711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SealevelTokenAdapterfrom warp-routes-UI #2684, migrates the EvmAdapter and missing utils from the warp UIDrive-by changes
Related issues
Required for #2652
Fixes #2546
Backward compatibility
Yes
Testing
Tested these in warp UI