-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate SealevelTokenAdapter
from warp-routes-UI
#2684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2684 +/- ##
=======================================
Coverage 64.50% 64.50%
=======================================
Files 91 91
Lines 1386 1386
Branches 185 185
=======================================
Hits 894 894
Misses 485 485
Partials 7 7 ☔ View full report in Codecov by Sentry. |
jmrossy
requested changes
Aug 25, 2023
typescript/sdk/src/router/adapters/SealevelRouterAdapter.test.ts
Outdated
Show resolved
Hide resolved
typescript/sdk/src/router/adapters/SealevelRouterAdapter.test.ts
Outdated
Show resolved
Hide resolved
jmrossy
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed the conflicts and build errors. Looks good!
jmrossy
added a commit
that referenced
this pull request
Sep 13, 2023
### Description - Build on #2684, migrates the EvmAdapter and missing utils from the warp UI - Remove the token App as it's unused and redundant with adapters - Add IGP serialization code for #2546 - Simplify multi-protocol adapters in SDK - Make token adapters extend base adapters - Move token serialization code to token package ### Drive-by changes - Update Sepolia RPC which was causing errors ### Related issues #2652 ### Backward compatibility Yes ### Testing Tested these in warp UI --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SealevelTokenAdapter
to monorepo for providing a common abstractiontokenSerialization
undersdk/utils/
Drive-by changes
SealevelRouterAdapter
schemaSealevelTokenAdapter
test to reflect the new interchain_gas_paymaster addition to accountRelated issues
Backward compatibility
Yes
Testing
Manual