Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SealevelTokenAdapter from warp-routes-UI #2684

Merged
merged 24 commits into from
Sep 4, 2023
Merged

Conversation

aroralanuk
Copy link
Contributor

@aroralanuk aroralanuk commented Aug 23, 2023

Description

  • Migrating SealevelTokenAdapter to monorepo for providing a common abstraction
  • Common tokenSerialization under sdk/utils/

Drive-by changes

  • Updating SealevelRouterAdapter schema
  • Updating SealevelTokenAdapter test to reflect the new interchain_gas_paymaster addition to account

Related issues

Backward compatibility

Yes

Testing

Manual

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f08ceb1) 64.50% compared to head (c5ea21a) 64.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2684   +/-   ##
=======================================
  Coverage   64.50%   64.50%           
=======================================
  Files          91       91           
  Lines        1386     1386           
  Branches      185      185           
=======================================
  Hits          894      894           
  Misses        485      485           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

typescript/sdk/src/index.ts Outdated Show resolved Hide resolved
typescript/sdk/src/utils/sealevel/tokenSerialization.ts Outdated Show resolved Hide resolved
typescript/sdk/src/utils/sealevel/tokenSerialization.ts Outdated Show resolved Hide resolved
typescript/token/src/globalTypes.ts Outdated Show resolved Hide resolved
typescript/token/src/adaptors/ITokenAdapter.ts Outdated Show resolved Hide resolved
typescript/token/src/adaptors/ITokenAdapter.ts Outdated Show resolved Hide resolved
typescript/token/src/adaptors/SealevelTokenAdapter.ts Outdated Show resolved Hide resolved
typescript/sdk/src/utils/sealevel/tokenSerialization.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the conflicts and build errors. Looks good!

@jmrossy jmrossy merged commit 86f2731 into main Sep 4, 2023
22 checks passed
@jmrossy jmrossy deleted the sealevelTokenAdapter branch September 4, 2023 19:50
jmrossy added a commit that referenced this pull request Sep 13, 2023
### Description

- Build on #2684, migrates the EvmAdapter and missing utils from the warp UI
- Remove the token App as it's unused and redundant with adapters
- Add IGP serialization code for #2546 
- Simplify multi-protocol adapters in SDK
- Make token adapters extend base adapters
- Move token serialization code to token package

### Drive-by changes

- Update Sepolia RPC which was causing errors

### Related issues

#2652 

### Backward compatibility

Yes

### Testing

Tested these in warp UI

---------

Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants