Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resistant TX confirmation #97

Closed
ggwpez opened this issue Jun 7, 2021 · 0 comments · Fixed by #101
Closed

Resistant TX confirmation #97

ggwpez opened this issue Jun 7, 2021 · 0 comments · Fixed by #101
Milestone
Ethereum Mainnet

Comments

@ggwpez
Copy link
Contributor

ggwpez commented Jun 7, 2021 •
edited
Loading

Location: [backend/eth/channel] contractbackend.go

Problem: TX are assumed to be final after one block, which is not the case for a reorg.

Solution: Implement a modified version of ContractBackend.ConfirmTransaction which checks that the Transaction is included in at least TxBlockFinality blocks.
TxBlockFinality is a new package constant of [backend/eth/channel]. Value to be discussed in #98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Ethereum Mainnet
Development

Successfully merging a pull request may close this issue.

Confirm TX with Finality Depth perun-network/go-perun
1 participant
@ggwpez