Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages with an empty ~thread decorator #2259

Closed
usingtechnology opened this issue Jun 8, 2023 · 1 comment · Fixed by #2261
Closed

Messages with an empty ~thread decorator #2259

usingtechnology opened this issue Jun 8, 2023 · 1 comment · Fixed by #2261

Comments

@usingtechnology
Copy link
Contributor

0.8.1 is sending messages with an empty ~thread.

This can confuse callers as RFC 0008 appears ambiguous; it states what to do if ~thread has not thid and what to do if no ~thread, but not what to do with ~thread with no thid.

If ACA-Py has no data in the ~thread, then let's not include it.

See hyperledger/aries-vcx#875

@usingtechnology
Copy link
Contributor Author

After looking through ACA-Py code, it is pretty clear that thid is not always expected to be populated in a ~thread, so I think we need to do this on a case-by-case basis.

However, the code clearly shows that thid was intended to be populated for credential-offer and there is a bug here. I will file a PR to address that bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant