Initial DIDComm v2 envelope support via Askar backend #1331
Conversation
|
What about adding a "DIDComm2Envelopes.md" that talks about how to use this? How do we get this tested? @ianco @shaangill025 -- can you please take a look at the code, at least? Thanks! This is another very cool addition. |
|
Also -- is there any feedback to add to RFC 587 after the implementation? I know you are commenting in the DIDComm2 Working Group, but wanted to make sure what's needed is getting back to the Aries community. Thanks! |
|
@swcurran There isn't really a way to use it at the moment, at least for agent-to-agent communication. We still need to implement a standard key lookup interface for the agent's own DID document keys as well as other agents' keys via the DID resolver (and cache). This is mainly a proof of concept to see what the complexity is and what it left to do. |
|
OK -- perhaps @troyronda and @Baha-sk might be interested in taking a look? |
Codecov Report
@@ Coverage Diff @@
## main #1331 +/- ##
==========================================
+ Coverage 95.75% 95.82% +0.07%
==========================================
Files 485 488 +3
Lines 29779 30009 +230
==========================================
+ Hits 28515 28757 +242
+ Misses 1264 1252 -12 |
andrewwhitehead
force-pushed
the
didcomm-initial
branch
from
9c883cf
to
3619c5e
Compare
andrewwhitehead
force-pushed
the
didcomm-initial
branch
from
3619c5e
to
e4dd549
Compare
andrewwhitehead
force-pushed
the
didcomm-initial
branch
from
8e0a1d4
to
5ff2542
Compare
…tes to JWE handling Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
… and variables for consistency Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
didcomm-initial
branch
from
5ff2542
to
8022586
Compare
|
@andrewwhitehead -- can you please update. @ianco, once done, can you please review? Thanks! |
Also cleans up and relocates the (incomplete) in-memory ECDH-1PU support.
This does not make the DIDComm v2 envelope format(s) available for communication yet, it only establishes some of the basic functionality.