Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OOB: Fixes issues with multiple public explicit invitation and unused 0160 connection #1525

Merged
merged 1 commit into from
Dec 1, 2021
Merged

OOB: Fixes issues with multiple public explicit invitation and unused 0160 connection #1525

merged 1 commit into from
Dec 1, 2021

Conversation

shaangill025
Copy link
Contributor

Signed-off-by: Shaanjot Gill gill.shaanjots@gmail.com

  • resolves Multiple explicit Out-Of-Band invitations with public DID #1524
  • Updated ConnectionManager and DIDXManager to look up ConnRecord by invitation_msg_id
  • Also fixes the issue, when an OOB invitation [0160 and with public DID] is accepted by the invitee, on the inviter side, a new ConnRecord is created and activated, and the original ConnRecord created along with the invitation remains unused.

@shaangill025
fix
ff91cab 
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
@kakao-jun-e kakao-jun-e mentioned this pull request Dec 1, 2021
Closed
@ianco ianco merged commit 67539b9 into openwallet-foundation:main Dec 1, 2021
@swcurran swcurran mentioned this pull request Dec 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianco ianco ianco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple explicit Out-Of-Band invitations with public DID
2 participants
@shaangill025 @ianco