Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow querying credentials for proof request with multiple referents #181

Merged
merged 4 commits into from
Sep 17, 2019

Conversation

nrempel
Copy link
Contributor

@nrempel nrempel commented Sep 17, 2019

This pull request allows the controller to query for credentials for a proof request for multiple referents at once:

"/presentation_exchange/{id}/credentials/{referent}"

can also be called as

"/presentation_exchange/{id}/credentials/{referent_1},{referent_2},{referent_3}"

Multiple referents should be passed as a comma delimited string.

Existing behaviour does not change for a single referent

Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #181 into master will increase coverage by <.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   71.67%   71.68%   +<.01%     
==========================================
  Files         217      217              
  Lines        9826     9828       +2     
==========================================
+ Hits         7043     7045       +2     
  Misses       2783     2783

Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
@andrewwhitehead andrewwhitehead merged commit abfd95b into openwallet-foundation:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants