fix: resolve dids following new endpoint rules #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Codecov Report
@@ Coverage Diff @@
## main #1863 +/- ##
==========================================
+ Coverage 93.79% 93.80% +0.01%
==========================================
Files 539 539
Lines 34081 34101 +20
==========================================
+ Hits 31967 31990 +23
+ Misses 2114 2111 -3 |
dbluhm
commented
Jul 18, 2022
TimoGlastra
previously approved these changes
Jul 19, 2022
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
| service_endpoint=endpoint_url, | ||
| recipient_keys=[recipient_key.id], | ||
| routing_keys=routing_keys, | ||
| accept=["didcomm/v2"], |
There was a problem hiding this comment.
Isn't it an issue that it resolves to accept only didcomm/v2, while we don't actually support that yet? Or does it not matter because this endpoint isn't examined anyway.
There was a problem hiding this comment.
Yeah, I think in this case, we're just constructing the DID Document as the DID Method spec outlines and whether we use the all of the services outlined in the doc is another question. We will be essentially ignoring them for now since we're only looking for the did-communication type.
andrewwhitehead
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naive solution to the issue raised by @TimoGlastra in #1313.