Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid throwing exception on invalid or incomplete received presentations #359

Conversation

andrewwhitehead
Copy link
Contributor

No description provided.

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
sklump
sklump previously approved these changes Feb 3, 2020
Copy link
Contributor

@sklump sklump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK.

I am a fan of python enums. I wish we'd put them into base_record for status, role, etc.

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #359 into master will decrease coverage by 0.02%.
The diff coverage is 84.84%.

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
- Coverage   89.24%   89.21%   -0.03%     
==========================================
  Files         236      236              
  Lines       11187    11203      +16     
==========================================
+ Hits         9984     9995      +11     
- Misses       1203     1208       +5

@swcurran swcurran merged commit 1291e0a into openwallet-foundation:master Feb 4, 2020
@andrewwhitehead andrewwhitehead deleted the fix/incomplete-presentation branch February 29, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants