Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature set/get endpoints of different types on ledger (resolves #589) #634

Closed

Conversation

domwoe
Copy link

@domwoe domwoe commented Jul 29, 2020

Signed-off-by: Woerner Dominic (RBCH/PJ-IOT) dominic.woerner2@ch.bosch.com

Signed-off-by: Woerner Dominic (RBCH/PJ-IOT) <dominic.woerner2@ch.bosch.com>
@codecov-commenter
Copy link

Codecov Report

Merging #634 into master will decrease coverage by 0.00%.
The diff coverage is 97.18%.

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
- Coverage   97.51%   97.51%   -0.01%     
==========================================
  Files         250      250              
  Lines       13345    13396      +51     
==========================================
+ Hits        13014    13063      +49     
- Misses        331      333       +2     

@domwoe
Copy link
Author

domwoe commented Aug 17, 2020

@sklump any feedback on how to move that forward?

@sklump
Copy link
Contributor

sklump commented Aug 17, 2020

Is there a need to allow for provisioning with different endpoint types? Since only endpoint_type==EndpointType.ENDPOINT affects the wallet, I am guessing that there is no such need?

@sklump
Copy link
Contributor

sklump commented Aug 17, 2020

I've merged master and completed unit test coverate in #667.

Is this good to go? Please comment there.

@sklump sklump closed this Aug 17, 2020
@sklump sklump mentioned this pull request Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants