feat(rest): added filters to getAllCredentials

[jimezesinachi]

No description provided.

[codecov-commenter]

Codecov Report

Merging #166 (e0e4031) into main (dcd8a85) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   86.24%   86.15%   -0.09%     
==========================================
  Files          21       21              
  Lines        1163     1163              
  Branches      260      257       -3     
==========================================
- Hits         1003     1002       -1     
- Misses        146      147       +1     
  Partials       14       14              

Impacted Files	Coverage Δ
packages/rest/src/routes/routes.ts	86.58% <ø> (ø)
...rc/controllers/connections/ConnectionController.ts	81.48% <100.00%> (-2.45%)	⬇️
...rc/controllers/credentials/CredentialController.ts	87.62% <100.00%> (+0.26%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[TimoGlastra]

Awesome. Tested locally and it works good! Left some notes on how to make it a bit more efficient when working with large amounts of records

[TimoGlastra]

Does it work if we use CredentialState as the type here? Maybe that'll give better validation and documentation in the swagger ui?

[TimoGlastra]

[TimoGlastra]

Ah I see this is also done like this in the connections controller, but we should actually filter in the query, to not retrieve records that aren't needed.

We should expose this in AFJ (I'll create an issue for this), but for now we can do it like this:

    const credentialRepository = this.agent.dependencyManager.resolve(CredentialRepository)

    const credentials = await credentialRepository.findByQuery({
      connectionId,
      threadId,
      state,
    })

    return credentials.map((c) => c.toJSON())

When this is merged, could you also make a PR to update this for the connections controller?

@janrtvld FYI

[TimoGlastra]

openwallet-foundation/credo-ts#1022

[TimoGlastra]

As we mock the results, we aren't testing whether te query is correctly applied here.

I think we should spy on the credential repository and see if it was called with the correct parameters:

  describe('Get all credentials by state', () => {
    test('should return all credentials', async () => {
      const credentialRepository = bobAgent.dependencyManager.resolve(CredentialRepository)
      const findByQuerySpy = jest.spyOn(credentialRepository, 'findByQuery').mockResolvedValueOnce([testCredential])

      const response = await request(app).get('/credentials').query({ state: testCredential.state })

      expect(findByQuerySpy).toBeCalledWith({
        state: testCredential.state,
      })

      expect(response.statusCode).toBe(200)
      expect(response.body).toEqual([testCredential].map(objectToJson))
    })
  })

[jimezesinachi]

Got it! I'll make the changes now

[TimoGlastra]

🚀 🚀 🚀

[TimoGlastra]

🚀

[TimoGlastra]

DCO is failing for some commits (seems the last two).

Can you sign off these commits by following these instructions: https://github.com/hyperledger/aries-rfcs/blob/main/contributing.md#how-to-sign-off-previous-commits? Then I'll merge