Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest): added WebSocket event server #170

Merged
merged 10 commits into from
Sep 21, 2022

Conversation

jimezesinachi
Copy link
Contributor

Signed-off-by: Jim Ezesinachi jim@animo.id

@jimezesinachi jimezesinachi requested a review from a team as a code owner September 19, 2022 12:33
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start @rapaktech!

Could you also add some tests that tests whether the websocket events are emitted?

packages/rest/package.json Show resolved Hide resolved
packages/rest/src/events/WebSocketEvents.ts Outdated Show resolved Hide resolved
packages/rest/src/events/WebSocketEvents.ts Outdated Show resolved Hide resolved
packages/rest/src/server.ts Outdated Show resolved Hide resolved
packages/rest/package.json Outdated Show resolved Hide resolved
packages/rest/package.json Outdated Show resolved Hide resolved
packages/rest/src/events/WebSocketEvents.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022

Codecov Report

Merging #170 (2e6e6df) into main (5458e9e) will increase coverage by 0.16%.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   86.22%   86.38%   +0.16%     
==========================================
  Files          21       23       +2     
  Lines        1183     1212      +29     
  Branches      261      273      +12     
==========================================
+ Hits         1020     1047      +27     
- Misses        149      151       +2     
  Partials       14       14              
Impacted Files Coverage Δ
packages/rest/src/events/CredentialEvents.ts 90.90% <85.71%> (-9.10%) ⬇️
packages/rest/src/events/ProofEvents.ts 90.90% <85.71%> (-9.10%) ⬇️
packages/rest/src/events/BasicMessageEvents.ts 100.00% <100.00%> (ø)
packages/rest/src/events/ConnectionEvents.ts 100.00% <100.00%> (ø)
packages/rest/src/events/WebSocketEvents.ts 100.00% <100.00%> (ø)
packages/rest/src/index.ts 100.00% <100.00%> (ø)
packages/rest/src/server.ts 78.72% <100.00%> (-0.87%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jimezesinachi and others added 9 commits September 21, 2022 12:12
Signed-off-by: Jim Ezesinachi <jim@animo.id>
Signed-off-by: Jim Ezesinachi <jim@animo.id>
Signed-off-by: Jim Ezesinachi <jim@animo.id>
This reverts commit 8ae2d28.

Signed-off-by: Jim Ezesinachi <jim@animo.id>
Signed-off-by: Jim Ezesinachi <ezesinachijim@gmail.com>
Signed-off-by: Jim Ezesinachi <jim@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Jim Ezesinachi <jim@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Jim Ezesinachi <jim@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Jim Ezesinachi <jim@animo.id>
Signed-off-by: Jim Ezesinachi <jim@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra changed the title feat(rest): added WebSocket event server and listeners feat(rest): added WebSocket event server Sep 21, 2022
@TimoGlastra TimoGlastra enabled auto-merge (squash) September 21, 2022 11:17
@TimoGlastra TimoGlastra merged commit e190821 into openwallet-foundation:main Sep 21, 2022
@jimezesinachi jimezesinachi deleted the issue#155 branch September 30, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants