Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Metamask links for excluded list #537

Closed
MadelineMurray opened this issue Oct 30, 2020 · 3 comments · Fixed by #539
Closed

Remove Metamask links for excluded list #537

MadelineMurray opened this issue Oct 30, 2020 · 3 comments · Fixed by #539
Assignees
Labels
DocOps Related to documentation system, tools and CI

Comments

@MadelineMurray
Copy link
Contributor

I added the following links to the ignore list because they were failing the link checker but are not broken:

{
            "pattern": "https://metamask.zendesk.com/hc/en-us/articles/360015489331-Importing-an-Account-New-UI-"
        },
        {
            "pattern": "https://metamask.zendesk.com/hc/en-us/articles/360015289452-Creating-Additional-MetaMask-Wallets-New-UI-"
        },
        {
            "pattern": "https://metamask.zendesk.com/hc/en-us/articles/360015488991-Sending-Ether-New-UI-"
        }, 

Need to investigate why they are causing the link checker to fail currently, fix, and then remove from ignore list.

@NicolasMassart
Copy link
Contributor

I have to update the link checker on Besu (I did it on all other sites but Besu is not Consensys so not linked to the common repos). I think it should fix the issue.

@NicolasMassart NicolasMassart added the DocOps Related to documentation system, tools and CI label Nov 2, 2020
@NicolasMassart
Copy link
Contributor

But not only. Zendesk is protected by CloudFlare, as is Consensys website. CF issues a challenge (Captcha) to the user to make sure that it's not a bot. Our Link checker is indeed a bot, a nice one, but still a bot... so we can't access the pages on this domains. As I guess there will be more and more sites doing this, we will either need to ask each of them to ass our CI IP to their rules (good luck) or stop checking them.
I sadly think we don't have the choice and we need to exclude these sites when we find one.

@NicolasMassart
Copy link
Contributor

See tcort/markdown-link-check#109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DocOps Related to documentation system, tools and CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants