Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: sync crossing merge boundary failing pre-merge header validation rules #4208

Closed
garyschulte opened this issue Aug 2, 2022 · 0 comments
Labels
mainnet TeamChupa GH issues worked on by Chupacabara Team

Comments

@garyschulte
Copy link
Contributor

garyschulte commented Aug 2, 2022

Description

#4190 introduced a regression where a batch of blocks that cross TTD can fail to validate. For example, if 200 blocks are fetched to import and 100 of them are pre-merge, and 100 post-merge, the pre-merge block validator will get selected because we have not yet imported a block that crosses the terminal total difficulty.

Acceptance Criteria

  • fast sync block imports should use the correct/corresponding block header validators when importing batches, even if a batch crosses the terminal total difficulty block

Steps to Reproduce (Bug)

  1. fast sync ropsten using the merge commit of Feature/engine api override #4190

Expected behavior: [What you expect to happen]
all fast syncs complete

Actual behavior: [What actually happens]
all fast sync methods fail to import post-merge blocks

Frequency: [What percentage of the time does it occur?]
99.5% of the time (depending on the batch size and the roll of the dice where the block range boundary is)

@non-fungible-nelson non-fungible-nelson added the TeamChupa GH issues worked on by Chupacabara Team label Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mainnet TeamChupa GH issues worked on by Chupacabara Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants