Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throwaway Withdrawals Testnet Branch (withdrawal-devnet-3) #4818

Closed
wants to merge 119 commits into from
Closed

Throwaway Withdrawals Testnet Branch (withdrawal-devnet-3) #4818

wants to merge 119 commits into from

Commits on Dec 8, 2022

  1. Composition over inheritence 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    af166e6 View commit details
    Browse the repository at this point in the history

  2. wip 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    72b418f View commit details
    Browse the repository at this point in the history

  3. spotless 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2f8f7b6 View commit details
    Browse the repository at this point in the history

  4. removing unnecessary code 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    7cfdd52 View commit details
    Browse the repository at this point in the history

  5. fixing npe 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3cbfc1e View commit details
    Browse the repository at this point in the history

  6. using of shanghai schedule for Reference tests 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2687f7e View commit details
    Browse the repository at this point in the history

  7. Using the shanghai Timestamp 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2d5db69 View commit details
    Browse the repository at this point in the history

  8. spotless 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    31e9329 View commit details
    Browse the repository at this point in the history

  9. Minor renaming 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    71417fc View commit details
    Browse the repository at this point in the history

  10. More minor renaming 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    eb7dbc6 View commit details
    Browse the repository at this point in the history

  11. Add unit test for TimestampScheduleBuilder 

    Add cancun timestamp and definition so getByTimestamp can be tested for correct ordering

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    870c84c View commit details
    Browse the repository at this point in the history

  12. validate block using correct protocol spec 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    f9303bf View commit details
    Browse the repository at this point in the history

  13. create block using correct protocol spec 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    d80952b View commit details
    Browse the repository at this point in the history

  14. validate fork timestamp order and more tests for TimestampScheduleBui… 

    …lder

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    dc15325 View commit details
    Browse the repository at this point in the history

  15. Add TransitionProtocolSchedule tests and fix make unnecessary eager e… 

    …valuation lazy

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    582a8ff View commit details
    Browse the repository at this point in the history

  16. Add test for ProtocolSchedule.getByBlockHeader 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    cfc8ecf View commit details
    Browse the repository at this point in the history

  17. Added tests for TimestampSchedule and minimised visibility 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5cb9bc1 View commit details
    Browse the repository at this point in the history

  18. Tentatively add TimestampProtocolSpecAdapters so it can be discussed 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    44f4631 View commit details
    Browse the repository at this point in the history

  19. Add pom checksum 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    7aeaecb View commit details
    Browse the repository at this point in the history

  20. Remove TODOs 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5ad6634 View commit details
    Browse the repository at this point in the history

  21. Fixed tests - only attempt to apply modifications if we have anything… 

    … in the timestamp schedule

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    0f251fd View commit details
    Browse the repository at this point in the history

  22. When block not found, throw instead of defaulting to the potentially … 

    …wrong schedule

This error is likely to happen and a followup PR should update getByBlockNumber to use getByBlockHeader

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    829e83c View commit details
    Browse the repository at this point in the history

  23. Add comment 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3fb6777 View commit details
    Browse the repository at this point in the history

  24. Missed some test modifications 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2480436 View commit details
    Browse the repository at this point in the history

  25. Add timestamp to toLogString for more info, not expecting it will be … 

    …called in reality though

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5954d89 View commit details
    Browse the repository at this point in the history

  26. Revert "When block not found, throw instead of defaulting to the pote… 

    …ntially wrong schedule"

This reverts commit 2756a9d.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    56edfa7 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. private and final 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    727325b View commit details
    Browse the repository at this point in the history

  2. Refactor TransitionUtils.getMergeContext, pull up PostMergeContext wi… 

    …ring

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    698849e View commit details
    Browse the repository at this point in the history

  3. Add PrivacySupportingProtocolSchedule interface and implement in Defa… 

    …ultTimestampSchedule

Support includes setPublicWorldStateArchiveForPrivacyBlockProcessor and setTransactionFilter methods

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    f4483ca View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. final 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    bf6eb04 View commit details
    Browse the repository at this point in the history

  2. Remove TimestampProtocolSpecAdapters 

    Use ProtocolSpecAdapters with a renamed field instead

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    e1522b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Refactor TimestampScheduleBuilder and ProtocolScheduleBuilder to use … 

    …template pattern

Add test coverage for ProtocolScheduleBuilder

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    06813e0 View commit details
    Browse the repository at this point in the history

  2. Add test and clarify names 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    34147d1 View commit details
    Browse the repository at this point in the history

  3. shanghaiTimestamp -> shanghaiTime 

    Also cancunTimestamp -> cancunTime

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    ac6db6b View commit details
    Browse the repository at this point in the history

  4. Withdrawals WIP 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    aae97a1 View commit details
    Browse the repository at this point in the history

  5. Compiling tests 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    9c7217a View commit details
    Browse the repository at this point in the history

  6. Reading of withdrawals is optional 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    83234b2 View commit details
    Browse the repository at this point in the history

  7. Adding validator index 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    564e527 View commit details
    Browse the repository at this point in the history

  8. Add withdrawals to payloadAttributes in fcU and add to block proprosal 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    0001fe5 View commit details
    Browse the repository at this point in the history

  9. New plugin-api hash following merge 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    4a05eec View commit details
    Browse the repository at this point in the history

  10. Fix withdrawal param parsing, fcU returns response now 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    a9d7602 View commit details
    Browse the repository at this point in the history

  11. Quantity param stuff, half finished 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    8c99677 View commit details
    Browse the repository at this point in the history

  12. Separate apis and stuff 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    bd95cb3 View commit details
    Browse the repository at this point in the history

  13. Fix withdrawal serialization 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    9a7e44e View commit details
    Browse the repository at this point in the history

  14. Support engine_newPayloadV2 and fix RLP bugs 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    09b5b3f View commit details
    Browse the repository at this point in the history

  15. Trying to get WithdrawalProcessor to work 

    Now getting Invalid block RLP while validating block during prepareBlock

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    94f4101 View commit details
    Browse the repository at this point in the history

  16. Fix test compile error from rebasing main 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    f88e51e View commit details
    Browse the repository at this point in the history

  17. Hacky fix for unit test 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    50aec44 View commit details
    Browse the repository at this point in the history

  18. Header now cares about withdrawals root being EMPTY 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    8be5622 View commit details
    Browse the repository at this point in the history

  19. Add toString to Withdrawal 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    2dd7fd3 View commit details
    Browse the repository at this point in the history

  20. Use UInt64 for Withdrawal index fields and fix hex serialization (toS… 

    …hortHexString)

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    f0a8d65 View commit details
    Browse the repository at this point in the history

  21. Adding shanghai fork as a block number 

    This is probably temporary measure and we will need to detect the block using a timestamp in the future
The shanghai.json is useless probably now

Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    642be96 View commit details
    Browse the repository at this point in the history

  22. withdrawals are now optional 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    0a74d39 View commit details
    Browse the repository at this point in the history

  23. Not sure why this one works over the other 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    ec16f12 View commit details
    Browse the repository at this point in the history

  24. spotless 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    0cf25c7 View commit details
    Browse the repository at this point in the history

  25. Add pre-shanghai validation to V2 to support CLs sending V2 before Ca… 

    …pella.

This commit might break post-shanghai V2 until I switch the validation depending on the fork.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    2bf241a View commit details
    Browse the repository at this point in the history

  26. Handle null withdrawals in newPayloadV2 

    Hacky pre/post shanghai validation

Serialize UInt64 toQuantityHexString instead of toShortHexString so 0 is returned as "0x0" instead of "0x"

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    11f3b45 View commit details
    Browse the repository at this point in the history

  27. Support pre/post-shanghai in ForkChoiceUpdatedV2 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    fa0a7db View commit details
    Browse the repository at this point in the history

  28. Allow post-shanghai (AllowedWithdrawals) to work with V1 requests tha… 

    …t contain null withdrawals

This means shanghai can be activated before capella which makes devnets a lot smoother, rather than having to perfectly align capella timestamp with shanghaiBlock

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    f686447 View commit details
    Browse the repository at this point in the history

  29. validate payload attributes based on chainHead + 1 shanghai activatio… 

    …n rules

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    cbbdaa1 View commit details
    Browse the repository at this point in the history

  30. Disallow post-shanghai (AllowedWithdrawals) to work with V1 requests … 

    …that contain null withdrawals

This was previously allowed to help with interop with clients that sometimes sent fcuV1 post-capella, but it was off-spec.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    df82113 View commit details
    Browse the repository at this point in the history

  31. Improve logging 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    731e4bb View commit details
    Browse the repository at this point in the history

  32. include withdrawalsRoot in eth_getBlock RPCs when it's not empty 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    7086f2a View commit details
    Browse the repository at this point in the history

  33. Use empty trie hash in genesis for withdrawalsRoot if shanghai is ena… 

    …bled at genesis

Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    2e4cf76 View commit details
    Browse the repository at this point in the history

  34. Composition over inheritence 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    756dc01 View commit details
    Browse the repository at this point in the history

  35. wip 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    c33bf34 View commit details
    Browse the repository at this point in the history

  36. spotless 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    6831a9d View commit details
    Browse the repository at this point in the history

  37. Fix compile after merging in timestamp changes 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    7949b90 View commit details
    Browse the repository at this point in the history

  38. Fix Besu controllers tests after genesis state change 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    21955e1 View commit details
    Browse the repository at this point in the history

  39. Change withdrawals genesis check to work off genesis timestamp 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    681da42 View commit details
    Browse the repository at this point in the history

  40. validator fcu params using correct protocol spec 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    8101200 View commit details
    Browse the repository at this point in the history

  41. Fix tests after merge 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    ee8bc3c View commit details
    Browse the repository at this point in the history

  42. Less hacky way of using timestamp proto schedule in engine API 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    6029c52 View commit details
    Browse the repository at this point in the history

  43. Minor renaming 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    8dfec0f View commit details
    Browse the repository at this point in the history

  44. Add unit test for TimestampScheduleBuilder 

    Add cancun timestamp and definition so getByTimestamp can be tested for correct ordering

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    cc8b7f4 View commit details
    Browse the repository at this point in the history

  45. validate block using correct protocol spec 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    4bb978c View commit details
    Browse the repository at this point in the history

  46. create block using correct protocol spec 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    4fe6015 View commit details
    Browse the repository at this point in the history

  47. ignore shanghai bootnode test until correct values are known 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    c0b432b View commit details
    Browse the repository at this point in the history

  48. add withdrawals back to shanghai definition after bad merge 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    060b317 View commit details
    Browse the repository at this point in the history

  49. Fix MainnetBlockBodyValidatorTest after change of MainnetBlockBodyVal… 

    …idator to use getByBlockHeader

Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    8bf6e46 View commit details
    Browse the repository at this point in the history

  50. ignore unknown properties on the engine fcu rpcs 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    a76991b View commit details
    Browse the repository at this point in the history

  51. revert accidental change to gradle.properties 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    41a0c5c View commit details
    Browse the repository at this point in the history

  52. Fix test after merge 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    e9d074a View commit details
    Browse the repository at this point in the history

  53. Fix compile error from git merge 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    bdc97f6 View commit details
    Browse the repository at this point in the history

  54. initial implemenation of fork id logic 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    29fc15b View commit details
    Browse the repository at this point in the history

  55. Wire up EIP-3651 - Warm Coinbase to shanghaiTime 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    682fb7f View commit details
    Browse the repository at this point in the history

  56. Fix compile error following cherry-pick 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    7759235 View commit details
    Browse the repository at this point in the history

  57. Wire up EIP-3855 PUSH0 to shanghaiTime and disable EOF (maxEofVersion… 

    …) in EvmSpecVersion.SHANGHAI

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    a47cce6 View commit details
    Browse the repository at this point in the history

  58. Wire up EIP-3860 - Limit and Meter Initcode to shanghaiTime 

    Used new contractSizeLimit (from shandong) but using PrefixCodeRule instead of CachedInvalidCodeRule since we don't want EOF enabled yet.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    36add07 View commit details
    Browse the repository at this point in the history

  59. fix ForkIdsTest 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    2a6a9e4 View commit details
    Browse the repository at this point in the history

  60. fix unit tests 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    a4ba2f9 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Fix more units related to ForkId fixes 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    37b72d6 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Add blockValue to EngineGetPayloadResultV2 

    Ported code over from hyperledger#4833

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    46f4390 View commit details
    Browse the repository at this point in the history

  2. Add withdrawals to BlockResult for eth_getBlockByHash and eth_getBloc… 

    …kByNumber

As per ethereum/execution-apis#334

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    161b70c View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Attempt to fix withdrawals sync issue - write withdrawals to RLP in B… 

    …lock (as well as BlockBodies)

Suspect the code path that receives blocks from EL peers isn't writing withdrawals to disk

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    27067a0 View commit details
    Browse the repository at this point in the history

  2. Revert "Wire up EIP-3860 - Limit and Meter Initcode to shanghaiTime" 

    This reverts commit 36add07.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    2a52a78 View commit details
    Browse the repository at this point in the history

  3. Revert "Wire up EIP-3855 PUSH0 to shanghaiTime and disable EOF (maxEo… 

    …fVersion) in EvmSpecVersion.SHANGHAI"

This reverts commit a47cce6.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    5543413 View commit details
    Browse the repository at this point in the history

  4. Revert "Wire up EIP-3651 - Warm Coinbase to shanghaiTime" 

    This reverts commit 682fb7f.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    a43135f View commit details
    Browse the repository at this point in the history

  5. Fix backwards sync issue - use getBlockByHeader to get timestamp sche… 

    …dule and enable shanghai

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    5abf19f View commit details
    Browse the repository at this point in the history

  6. Revert "Revert "Wire up EIP-3651 - Warm Coinbase to shanghaiTime"" 

    This reverts commit a43135f.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    fdf4b1f View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. Revert "Revert "Wire up EIP-3855 PUSH0 to shanghaiTime and disable EO… 

    …F (maxEofVersion) in EvmSpecVersion.SHANGHAI""

This reverts commit 5543413.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    42024ed View commit details
    Browse the repository at this point in the history

  2. Revert "Revert "Wire up EIP-3860 - Limit and Meter Initcode to shangh… 

    …aiTime""

This reverts commit 2a52a78.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    8bec319 View commit details
    Browse the repository at this point in the history

  3. Logging 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    5dd8a34 View commit details
    Browse the repository at this point in the history

  4. tweak paris def remove from mergespecific mods 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @garyschulte @siladu
    garyschulte authored and siladu committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    ddf785a View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. Revert "tweak paris def remove from mergespecific mods" 

    This reverts commit ddf785a.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    420ee05 View commit details
    Browse the repository at this point in the history

  2. For TimestampSchedule (Shanghai) remove evmBuilder override but leave… 

    … other mods in

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    0455b22 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2023

  1. EIP-3860 Initcode Size Reference Test fixes (hyperledger#4911) 

    * EIP-3860 Initcode Size Reference Test fixes

Fix corner cases around initcode size checking in reference tests.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
    @shemnon @siladu
    shemnon authored and siladu committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    901573c View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2023

  1. Fix invalid withdrawals root during backwards sync 

    Add withdrawalsRoot as part of BodyIdentifier
Add comment to avoid new issues when adding new fields to BlockBody

Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu @gfukushima
    siladu and gfukushima committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    fbf0e21 View commit details
    Browse the repository at this point in the history

  2. Allow -Pdocker-platform during distDocker (hyperledger#4828) 

    As an example of usecase - this should make it easier to build linux/amd64 images on M1.

Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>

Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
    @gezero @macfarla @siladu
    2 people authored and siladu committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    9b3f70a View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. Fix validation bug when V2 is called pre-shanghai 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    d1fbcc5 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Update engine apis 

    Signed-off-by: Zhenyang Shi <wcgcyx@gmail.com>
    @wcgcyx
    wcgcyx committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    53cb4ee View commit details
    Browse the repository at this point in the history

  2. Withdrawls - Change Amount type to GWei instead of Wei 

    Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
    @usmansaleem @gfukushima
    usmansaleem authored and gfukushima committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    da24270 View commit details
    Browse the repository at this point in the history

  3. Fix the invalid payload check order in the FCU and spotless 

    Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
    @gfukushima
    gfukushima committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    60f3d25 View commit details
    Browse the repository at this point in the history

  4. Fixed forkChoiceUpdate error code and tests 

    Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
    @gfukushima
    gfukushima committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    9fe062c View commit details
    Browse the repository at this point in the history

  5. Fix compile error in test 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    0cc7c2b View commit details
    Browse the repository at this point in the history

  6. Fix/Disable tests 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    f5a3201 View commit details
    Browse the repository at this point in the history

  7. Fix withdrawals tests by changing encoding/encoding to use UInt64 sca… 

    …lar for RLP instead of long scalar

Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe
    jframe committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    a7c96ca View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Fix block replay to work with Shanghai blocks 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    f97e694 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Add logging to help with bad block production 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    03c7f06 View commit details
    Browse the repository at this point in the history