[4844] Add encodingContext to TransactionEncoder and TransactionDecoder #5820

Gabriel-Trintinalia · 2023-08-29T06:38:57Z

PR description

Introduces a refactoring of TransactionDecoder and TransactionEncoder classes, incorporating an EncodingContext. This context specifies the decoding destination of the transaction, either the transaction pool or the block body.

This refactoring is required due to 4844, which presents BlobTransactiona that requires broadcasting to the network using a different encoding than the one used within a block body.

Main changes:

Inclusion of EncodingContext parameter in relevant methods.
Creation of dedicated classes for the Frontier, Access List, and 1559 transaction types, moving them out of the TransactionEncoder/Decoder classes.
Revisions to internal logic to leverage EncodingContext for decoding.
Renaming of decodeForWire method to decodeRLP for better clarity.
Adjustments to unit tests to consider the new context.

Fixed Issue(s)

Fixes #5818

Fixes hive tests:

blob_txs_full/reject_valid_full_blob_in_block_rlp/000-fork=Cancun-one_full_blob_one_tx
blob_txs_full/reject_valid_full_blob_in_block_rlp/001-fork=Cancun-one_full_blob_max_txs
blob_txs_full/reject_valid_full_blob_in_block_rlp/002-fork=Cancun-one_full_blob_at_the_end_max_txs

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

github-actions · 2023-08-29T06:39:06Z

I thought about documentation and added the doc-change-required label to this PR if updates are required.
I thought about the changelog and included a changelog update if required.
If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

jflo

I think we've stepped backwards a bit on the readability front, perhaps we should rethink/refactor what TransactionDecoders are and how they should be interacted with.

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/encoding/TransactionDecoder.java

jflo · 2023-08-29T17:09:50Z

We should also look at the encoding flow to make sure it is covered. Judging by this test:

https://hivecancun.ethdevops.io/suite.html?suiteid=1693318274-e8392753d17fdfc054e6216e11ef2a81.json&suitename=engine-cancun#test-44

It is probably not. The size mismatch suggests that we didn't gossip out the blobs/commitments/proofs etc.

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

…ub.com/Gabriel-Trintinalia/besu into add-decode-type-to-transaction-decoder

…transaction-decoder

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

…ub.com/Gabriel-Trintinalia/besu into add-decode-type-to-transaction-decoder

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/encoding/TransactionDecoder.java

macfarla · 2023-09-05T00:24:55Z

ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthServer.java

      final BytesValueRLPOutput txRlp = new BytesValueRLPOutput();
-      maybeTx.get().writeTo(txRlp);
+      TransactionEncoder.encodeRLP(maybeTx.get(), txRlp, EncodingContext.POOLED_TRANSACTION);


this line fixes the Versioned hashes from blob transactions do not match expected values error

...rg/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineNewPayloadV3Test.java

...ore/src/test/java/org/hyperledger/besu/ethereum/core/encoding/TransactionRLPDecoderTest.java

macfarla · 2023-09-05T00:37:11Z

.../src/main/java/org/hyperledger/besu/ethereum/core/encoding/BlobPooledTransactionEncoder.java

+import org.slf4j.Logger;
+
+public class BlobPooledTransactionEncoder {
+  private static final Logger LOG = getLogger(BlobPooledTransactionEncoder.class);


do we want matching trace logging in the decoder BlobPooledTransactionDecoder

Gabriel-Trintinalia · 2023-09-05T01:21:25Z

I think we've stepped backwards a bit on the readability front, perhaps we should rethink/refactor what TransactionDecoders are and how they should be interacted with.

Thanks for the input. I have considered it when developing. This PR has changed quite a bit now. Would you be able to have a look again @jflo

Gabriel-Trintinalia · 2023-09-05T01:22:42Z

We should also look at the encoding flow to make sure it is covered. Judging by this test:

https://hivecancun.ethdevops.io/suite.html?suiteid=1693318274-e8392753d17fdfc054e6216e11ef2a81.json&suitename=engine-cancun#test-44

It is probably not. The size mismatch suggests that we didn't gossip out the blobs/commitments/proofs etc.

This test should be fixed now I believe

pinges

Some comments and questions ...

...main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/BlockResultFactory.java

pinges · 2023-09-05T00:22:56Z

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/util/DomainObjectDecodeUtils.java

@@ -27,7 +28,7 @@ public static Transaction decodeRawTransaction(final String rawTransaction)
      throws InvalidJsonRpcRequestException {


should we rename this method or get rid of it? It does not reflect which format to decode now that we have the two different kinds ...

Any suggestions for names? It is used to handle the serialization in the RPC apis

pinges · 2023-09-05T00:27:29Z

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java

@@ -126,7 +128,7 @@ public static Transaction readFrom(final Bytes rlpBytes) {
  }

  public static Transaction readFrom(final RLPInput rlpInput) {


This can only decode one of the two encoding formats now. Should this be renamed? Should it decode both formats? Should we remove it and only rely on the TransactionDecoder?

pinges · 2023-09-05T00:27:49Z

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java

@@ -613,7 +615,7 @@ private Bytes32 getOrComputeSenderRecoveryHash() {
   * @param out the output to write the transaction to
   */
  public void writeTo(final RLPOutput out) {


pinges · 2023-09-05T00:52:45Z

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java

@@ -676,17 +678,19 @@ public int getSize() {
  }

  private void memoizeHashAndSize() {
-    final Bytes bytes = TransactionEncoder.encodeOpaqueBytes(this);
+    final Bytes bytes = TransactionEncoder.encodeOpaqueBytes(this, EncodingContext.BLOCK_BODY);
    hash = Hash.hash(bytes);

    if (transactionType.supportsBlob()) {
      if (getBlobsWithCommitments().isPresent()) {


Are we sure that we always want the size including the blobs when they are available? Or should we have a size and a size method that takes the encoding context as an argument?
It looks like size is only used in the TransactionAnnouncement. Should we rename it to announcementSize?

.../src/main/java/org/hyperledger/besu/ethereum/core/encoding/AccessListTransactionDecoder.java

.../src/main/java/org/hyperledger/besu/ethereum/core/encoding/AccessListTransactionEncoder.java

...m/core/src/main/java/org/hyperledger/besu/ethereum/core/encoding/BlobTransactionDecoder.java

pinges · 2023-09-05T02:46:08Z

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/encoding/TransactionDecoder.java

+   */
+  public static Transaction decodeOpaqueBytes(
+      final Bytes opaqueBytes, final EncodingContext context) {
+    var transactionType = getTransactionType(opaqueBytes);


is this now doing the same as the decodeRLP, just a RLPInput instead of the bytes?

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/encoding/TransactionDecoder.java

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

macfarla

LGTM

macfarla · 2023-09-12T04:03:37Z

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/encoding/TransactionDecoder.java

    } else {
-      throw new RuntimeException(
-          String.format("An unsupported encoded `v` value of %s was found", v));
+      // If the transaction type is not present, decode the opaque bytes as RLP


does this happen normally?

--- Drop Kotti Network support (ETC) (hyperledger#5816) Signed-off-by: Diego López León <dieguitoll@gmail.com> fix ForkId if there are no Forks and the starting timestamp is not 0 (hyperledger#5819) Signed-off-by: Stefan <stefan.pingel@consensys.net> enforce that BlobTransactions have at least one blob (hyperledger#5826) * enforce that BlobTransactions have at least one blob Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Do not create ignorable segments on `revert storage-variables` (hyperledger#5830) * fix the bug that creates the ignorable chain pruner segment, add rocks exception parsing to RocksDBColumnarKeyValueStorage subclasses * parse rocksdb error for unprintable column family id's Signed-off-by: garyschulte <garyschulte@gmail.com> add versioned hashes and number of blobs to toString() (hyperledger#5831) Signed-off-by: Stefan <stefan.pingel@consensys.net> add parent beacon block root to payload id calculation (hyperledger#5843) Signed-off-by: Stefan <stefan.pingel@consensys.net> bump version to 23.7.3-SNAPSHOT (hyperledger#5854) Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> set the beacon root address to the correct value (hyperledger#5853) Signed-off-by: Stefan <stefan.pingel@consensys.net> docs(readme): fix broken link to installation of binaries page (hyperledger#5859) Fixes hyperledger#5858 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> Update RocksDB version from 8.0.0 to 8.3.2 (hyperledger#5832) Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> use non-deprecated authenticate methods (hyperledger#5852) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> move to Hyperledger shared runners for current github actions (hyperledger#5860) Signed-off-by: garyschulte <garyschulte@gmail.com> Add range tracing with worldstate (hyperledger#5844) Implement a method to trace a range of blocks and have access to the worldstate before and after the tracing Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Layered txpool by default and txpool options hoverhaul (hyperledger#5772) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions (hyperledger#5857) Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> updated gradle verification metadata (hyperledger#5870) * removed old artefacts [skip ci] * works with compileTestJava * restored metadata needed for codeQL and trusted-artifacts block for javadoc/sources Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> [4844] Add encodingContext to TransactionEncoder and TransactionDecoder (hyperledger#5820) * Add decode type to TransactionDecoder * Refactoring TransactionDecoder * Invert methods order * Use Transaction encoder instead of writeTo * Move enter and leave list to inner method as pr suggestion * Size calculation should use opaque bytes instead of rlp --------- Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Stefan <stefan.pingel@consensys.net> payload attributes: fix wrong warning and fail if beacon root is available before cancun (hyperledger#5872) Signed-off-by: Stefan <stefan.pingel@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Merge MutableAccount and EVMAccount (hyperledger#5863) Merge MutableAccount and EVMAccount functionalities by removing EVMAccount, all calls to getMutable, and the WrappedEVMAccount that was wrapping non-EVMAccounts in a mutable fashion. Instead, use a MutableAccount in all cases an EVMAccount would have been used. This also tends to reduce a level of layering in many places. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Add world context to transaction tracing API (hyperledger#5836) * Add world context to transaction tracing API Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Update changelog with PR ID Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Add the Transaction to traceEndTransaction Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Rebase on main Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Add receipt-linked information to the transaction tracer Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * added test Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> --------- Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Bonsai based reference test worldstate (hyperledger#5686) * create a bonsai based reference test worldstate -> getOrCreate in BonsaiWorldStateUpdateAccumulator - do not throw if we discover an empty account in a non-null BonsaiValue<Account> -> add curentStateRoot to t8n -> storageEntriesFrom and streamAccounts implemented in BonsaiWorldStateKeyValueStorage -> add endKey version of streamFromKey * bonsai fix for self-destruct and create2 at the same address and same block Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Karim TAAM <karim.t2am@gmail.com> Don't start BFT mining coordinators until initial sync has completed (hyperledger#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Fix unit tests Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> display only peers ready for requets on ethstats (hyperledger#5880) * display only ready for requets peers in ethstats Signed-off-by: Karim TAAM <karim.t2am@gmail.com> * cast to int Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> [MINOR] test RLP used for encode/decode blob tx should contain to field (hyperledger#5883) * validate to field on encode/decode for blob tx Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * revert decode/encode checks - tis done later in tx validation Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Fix: correctly convert percentage options in TOML configuration file (hyperledger#5886) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> EIP7516 - Add BlobBaseFee opcode to Cancun EVM (hyperledger#5884) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Fix snapsync heal (hyperledger#5838) Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Upgrade besu-native (hyperledger#5893) Upgrade besu-native to 0.8.2 Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Tune G1GC to reduce Besu memory footprint (hyperledger#5879) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Add updated storage to evmtool json trace (hyperledger#5892) Add the EIP-3155 "storage" option to the standard tracer, with the caveat only updated storage is logged. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Update holesky with fixed extraData, genesis time, shanghaiTime (hyperledger#5890) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> [CHANGELOG] removed duplicated line (hyperledger#5904) * removed duplicated line [skip ci] Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * fixed spelling on Holesky Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

…er (hyperledger#5820) * Add decode type to TransactionDecoder * Refactoring TransactionDecoder * Invert methods order * Use Transaction encoder instead of writeTo * Move enter and leave list to inner method as pr suggestion * Size calculation should use opaque bytes instead of rlp --------- Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

…er (hyperledger#5820) * Add decode type to TransactionDecoder * Refactoring TransactionDecoder * Invert methods order * Use Transaction encoder instead of writeTo * Move enter and leave list to inner method as pr suggestion * Size calculation should use opaque bytes instead of rlp --------- Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com>

…er (hyperledger#5820) * Add decode type to TransactionDecoder * Refactoring TransactionDecoder * Invert methods order * Use Transaction encoder instead of writeTo * Move enter and leave list to inner method as pr suggestion * Size calculation should use opaque bytes instead of rlp --------- Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

burn-in candidate for 23.7.3 from main sha 6dc10a9..eef40bd https://github.com/hyperledger/besu/compare/6dc10a9..eef40bd --- * Drop Kotti Network support (ETC) (#5816) Signed-off-by: Diego López León <dieguitoll@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * fix ForkId if there are no Forks and the starting timestamp is not 0 (#5819) Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * enforce that BlobTransactions have at least one blob (#5826) * enforce that BlobTransactions have at least one blob Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Do not create ignorable segments on `revert storage-variables` (#5830) * fix the bug that creates the ignorable chain pruner segment, add rocks exception parsing to RocksDBColumnarKeyValueStorage subclasses * parse rocksdb error for unprintable column family id's Signed-off-by: garyschulte <garyschulte@gmail.com> * add versioned hashes and number of blobs to toString() (#5831) Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * add parent beacon block root to payload id calculation (#5843) Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * bump version to 23.7.3-SNAPSHOT (#5854) Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * set the beacon root address to the correct value (#5853) Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * docs(readme): fix broken link to installation of binaries page (#5859) Fixes #5858 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Update RocksDB version from 8.0.0 to 8.3.2 (#5832) Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * use non-deprecated authenticate methods (#5852) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * move to Hyperledger shared runners for current github actions (#5860) Signed-off-by: garyschulte <garyschulte@gmail.com> * Add range tracing with worldstate (#5844) Implement a method to trace a range of blocks and have access to the worldstate before and after the tracing Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Layered txpool by default and txpool options hoverhaul (#5772) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions (#5857) Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * updated gradle verification metadata (#5870) * removed old artefacts [skip ci] * works with compileTestJava * restored metadata needed for codeQL and trusted-artifacts block for javadoc/sources Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * [4844] Add encodingContext to TransactionEncoder and TransactionDecoder (#5820) * Add decode type to TransactionDecoder * Refactoring TransactionDecoder * Invert methods order * Use Transaction encoder instead of writeTo * Move enter and leave list to inner method as pr suggestion * Size calculation should use opaque bytes instead of rlp --------- Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * #5868: fix beacon root address and modulus for devnet 9 (#5871) Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * payload attributes: fix wrong warning and fail if beacon root is available before cancun (#5872) Signed-off-by: Stefan <stefan.pingel@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Merge MutableAccount and EVMAccount (#5863) Merge MutableAccount and EVMAccount functionalities by removing EVMAccount, all calls to getMutable, and the WrappedEVMAccount that was wrapping non-EVMAccounts in a mutable fashion. Instead, use a MutableAccount in all cases an EVMAccount would have been used. This also tends to reduce a level of layering in many places. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Add world context to transaction tracing API (#5836) * Add world context to transaction tracing API Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Update changelog with PR ID Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Add the Transaction to traceEndTransaction Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Rebase on main Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Add receipt-linked information to the transaction tracer Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * added test Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> --------- Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Bonsai based reference test worldstate (#5686) * create a bonsai based reference test worldstate -> getOrCreate in BonsaiWorldStateUpdateAccumulator - do not throw if we discover an empty account in a non-null BonsaiValue<Account> -> add curentStateRoot to t8n -> storageEntriesFrom and streamAccounts implemented in BonsaiWorldStateKeyValueStorage -> add endKey version of streamFromKey * bonsai fix for self-destruct and create2 at the same address and same block Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Don't start BFT mining coordinators until initial sync has completed (#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Fix unit tests Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * display only peers ready for requets on ethstats (#5880) * display only ready for requets peers in ethstats Signed-off-by: Karim TAAM <karim.t2am@gmail.com> * cast to int Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * [MINOR] test RLP used for encode/decode blob tx should contain to field (#5883) * validate to field on encode/decode for blob tx Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * revert decode/encode checks - tis done later in tx validation Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Fix: correctly convert percentage options in TOML configuration file (#5886) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * EIP7516 - Add BlobBaseFee opcode to Cancun EVM (#5884) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * Fix snapsync heal (#5838) Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Upgrade besu-native (#5893) Upgrade besu-native to 0.8.2 Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Tune G1GC to reduce Besu memory footprint (#5879) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * Add updated storage to evmtool json trace (#5892) Add the EIP-3155 "storage" option to the standard tracer, with the caveat only updated storage is logged. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Update holesky with fixed extraData, genesis time, shanghaiTime (#5890) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * [CHANGELOG] removed duplicated line (#5904) * removed duplicated line [skip ci] Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * fixed spelling on Holesky Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * add 23.7.2 release SHAs and bump to 23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-RC version Signed-off-by: garyschulte <garyschulte@gmail.com> --------- Signed-off-by: Diego López León <dieguitoll@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Diego López León <dieguitoll@gmail.com> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Co-authored-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Peter Somogyvari <petermetz@users.noreply.github.com> Co-authored-by: ahamlat <ameziane.hamlat@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: matkt <karim.t2am@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Co-authored-by: delehef <franklin.delehelle@odena.eu> Co-authored-by: Matt Whitehead <matthew1001@gmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net>

…er (hyperledger#5820) * Add decode type to TransactionDecoder * Refactoring TransactionDecoder * Invert methods order * Use Transaction encoder instead of writeTo * Move enter and leave list to inner method as pr suggestion * Size calculation should use opaque bytes instead of rlp --------- Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

Add decode type to TransactionDecoder

feaab57

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Merge branch 'main' into add-decode-type-to-transaction-decoder

1499768

Gabriel-Trintinalia added the 4844 label Aug 29, 2023

jflo reviewed Aug 29, 2023

View reviewed changes

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/encoding/TransactionDecoder.java Outdated Show resolved Hide resolved

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/encoding/TransactionDecoder.java Outdated Show resolved Hide resolved

Gabriel-Trintinalia changed the title ~~[4844] BlobTransactions - Add decodeType to TransactionDecoder~~ WIP [4844] BlobTransactions - Add decodeType to TransactionDecoder Aug 30, 2023

Gabriel-Trintinalia added 20 commits August 31, 2023 14:37

Refactoring TransactionDecoder

318bc16

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Merge main

59665a7

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Rename class

9f06b73

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Fix spotless

f31a783

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Change names

7b3f751

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Fix spotless

b20f6d4

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Invert methods order

ed726a4

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Add comments

ede2408

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Code simplification

a1402c8

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Code simplification

792e735

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Code simplification

3fdc9a9

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Code simplification

63124a1

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Code simplification

8594933

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

fix tests

b453cf7

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Add javadoc

a877c99

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Add javadoc

b678893

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Refactoring

8ee0c89

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Merge branch 'add-decode-type-to-transaction-decoder' of https://gith…

1f1fc12

…ub.com/Gabriel-Trintinalia/besu into add-decode-type-to-transaction-decoder

Merge branch 'transaction-encoding-refactor' into add-decode-type-to-…

88ba4bf

…transaction-decoder

Merge branch 'main' into add-decode-type-to-transaction-decoder

25a78ed

Gabriel-Trintinalia changed the title ~~WIP [4844] BlobTransactions - Add decodeType to TransactionDecoder~~ WIP [4844] Add encodingContext to TransactionEncoder and TransactionDecoder Sep 4, 2023

Gabriel-Trintinalia added 2 commits September 4, 2023 22:54

Use Transaction encoder instead of writeTo

0d62138

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Merge branch 'add-decode-type-to-transaction-decoder' of https://gith…

ea4651d

…ub.com/Gabriel-Trintinalia/besu into add-decode-type-to-transaction-decoder

macfarla reviewed Sep 5, 2023

View reviewed changes

pinges reviewed Sep 5, 2023

View reviewed changes

Gabriel-Trintinalia added 6 commits September 5, 2023 19:55

Merge branch 'main' into add-decode-type-to-transaction-decoder

c99cb7c

Move enter and leave list to inner method as pr suggestion

80a10b8

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Size calculation should use opaque bytes instead of rlp

30eca31

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

PR suggestions

987a4a5

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Fix spotless

b57c906

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Merge branch 'main' into add-decode-type-to-transaction-decoder

2084eff

Gabriel-Trintinalia changed the title ~~WIP [4844] Add encodingContext to TransactionEncoder and TransactionDecoder~~ [4844] Add encodingContext to TransactionEncoder and TransactionDecoder Sep 8, 2023

Gabriel-Trintinalia marked this pull request as ready for review September 12, 2023 03:34

macfarla approved these changes Sep 12, 2023

View reviewed changes

macfarla added 2 commits September 13, 2023 09:03

Merge branch 'main' into add-decode-type-to-transaction-decoder

386112e

Merge branch 'main' into add-decode-type-to-transaction-decoder

ef7fc75

macfarla enabled auto-merge (squash) September 13, 2023 05:05

macfarla merged commit 1fa21e2 into hyperledger:main Sep 13, 2023
18 of 19 checks passed

siladu mentioned this pull request Sep 20, 2023

Burn in release of 23.7.3 from main (inclusive of sha eef40bd) #5905

Closed

Gabriel-Trintinalia deleted the add-decode-type-to-transaction-decoder branch September 20, 2023 06:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4844] Add encodingContext to TransactionEncoder and TransactionDecoder #5820

[4844] Add encodingContext to TransactionEncoder and TransactionDecoder #5820

Gabriel-Trintinalia commented Aug 29, 2023 •

edited

Loading

github-actions bot commented Aug 29, 2023

jflo left a comment

jflo commented Aug 29, 2023

macfarla Sep 5, 2023

macfarla Sep 5, 2023

Gabriel-Trintinalia commented Sep 5, 2023

Gabriel-Trintinalia commented Sep 5, 2023

pinges left a comment

pinges Sep 5, 2023

Gabriel-Trintinalia Sep 5, 2023

pinges Sep 5, 2023

pinges Sep 5, 2023

pinges Sep 5, 2023

pinges Sep 5, 2023

macfarla left a comment

macfarla Sep 12, 2023

		@@ -27,7 +28,7 @@ public static Transaction decodeRawTransaction(final String rawTransaction)
		throws InvalidJsonRpcRequestException {

		@@ -126,7 +128,7 @@ public static Transaction readFrom(final Bytes rlpBytes) {
		}

		public static Transaction readFrom(final RLPInput rlpInput) {

[4844] Add encodingContext to TransactionEncoder and TransactionDecoder #5820

[4844] Add encodingContext to TransactionEncoder and TransactionDecoder #5820

Conversation

Gabriel-Trintinalia commented Aug 29, 2023 • edited Loading

PR description

Fixed Issue(s)

github-actions bot commented Aug 29, 2023

jflo left a comment

Choose a reason for hiding this comment

jflo commented Aug 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Gabriel-Trintinalia commented Sep 5, 2023

Gabriel-Trintinalia commented Sep 5, 2023

pinges left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

macfarla left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Gabriel-Trintinalia commented Aug 29, 2023 •

edited

Loading