Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4844] Add encodingContext to TransactionEncoder and TransactionDecoder #5820
[4844] Add encodingContext to TransactionEncoder and TransactionDecoder #5820
Changes from 24 commits
feaab57
1499768
318bc16
59665a7
9f06b73
f31a783
7b3f751
b20f6d4
ed726a4
ede2408
a1402c8
792e735
3fdc9a9
63124a1
8594933
b453cf7
a877c99
b678893
8ee0c89
1f1fc12
88ba4bf
25a78ed
0d62138
ea4651d
c99cb7c
80a10b8
30eca31
987a4a5
b57c906
2084eff
386112e
ef7fc75
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we rename this method or get rid of it? It does not reflect which format to decode now that we have the two different kinds ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any suggestions for names? It is used to handle the serialization in the RPC apis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can only decode one of the two encoding formats now. Should this be renamed? Should it decode both formats? Should we remove it and only rely on the TransactionDecoder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s.a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that we always want the size including the blobs when they are available? Or should we have a size and a size method that takes the encoding context as an argument?
It looks like size is only used in the TransactionAnnouncement. Should we rename it to announcementSize?