Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(connector-iroha2): fix flaky iroha2-setup-and-basic-operations #2373

Closed
petermetz opened this issue Apr 6, 2023 · 0 comments · Fixed by #2381
Closed

test(connector-iroha2): fix flaky iroha2-setup-and-basic-operations #2373

petermetz opened this issue Apr 6, 2023 · 0 comments · Fixed by #2381
Assignees
@petermetz
Labels
bug Something isn't working Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) good-first-issue Good for newcomers good-first-issue-400-expert Iroha Bugs/features related to the Iroha ledger connector plugin P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.

Comments

@petermetz
Copy link
Contributor

petermetz commented Apr 6, 2023 •
edited
Loading

Describe the bug

The flaky test case file in question:
packages/cactus-plugin-ledger-connector-iroha2/src/test/typescript/integration/iroha2-setup-and-basic-operations.test.ts

To Reproduce

Run the CI enough times that it fails again. Unfortunately I could not reproduce it locally at all.

Expected behavior

Test succeeds consistently across different environments.

Logs/Stack traces

2023-04-06T01-10-50-connector-iroha2-ci-test-crash.log

Cloud provider or hardware configuration:

GitHub/BuildJet runners

Operating system name, version, build:

Ubuntu-20.04

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

main

Hyperledger Cactus Plugins/Connectors Used

iroha2

cc: @outSH
@petermetz petermetz added bug Something isn't working good-first-issue Good for newcomers good-first-issue-400-expert Iroha Bugs/features related to the Iroha ledger connector plugin Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) Tests Anything related to tests be that automatic or manual, integration or unit, etc. P3 Priority 3: Medium labels Apr 6, 2023
@petermetz petermetz self-assigned this Apr 6, 2023
outSH added a commit to outSH/cactus that referenced this issue Apr 7, 2023
@outSH
fix(iroha2-connector): fix flaky tests
ce04851 
- Use waitForCommit for all transactions used in test suites to prevent spurious CI test failures.

Closes: hyperledger-cacti#2370
Closes: hyperledger-cacti#2373

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@outSH outSH mentioned this issue Apr 7, 2023
Merged
outSH added a commit to outSH/cactus that referenced this issue Apr 11, 2023
@outSH
fix(iroha2-connector): fix flaky tests to solve hyperledger-cacti#2370 …
f433ad9 
…and hyperledger-cacti#2373

- Use waitForCommit for all transactions used in test suites to prevent spurious CI test failures.

Closes: hyperledger-cacti#2370
Closes: hyperledger-cacti#2373

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
ryjones pushed a commit to outSH/cactus that referenced this issue Apr 11, 2023
@outSH @ryjones
fix(iroha2-connector): fix flaky tests to solve hyperledger-cacti#2370 …
d774951 
…and hyperledger-cacti#2373

- Use waitForCommit for all transactions used in test suites to prevent spurious CI test failures.

Closes: hyperledger-cacti#2370
Closes: hyperledger-cacti#2373

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz pushed a commit to outSH/cactus that referenced this issue Apr 11, 2023
@outSH @petermetz
fix(iroha2-connector): fix flaky tests to solve hyperledger-cacti#2370 …
4e0a574 
…and hyperledger-cacti#2373

- Use waitForCommit for all transactions used in test suites to prevent spurious CI test failures.

Closes: hyperledger-cacti#2370
Closes: hyperledger-cacti#2373

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
sandeepnRES pushed a commit to outSH/cactus that referenced this issue Apr 26, 2023
@outSH @sandeepnRES
fix(iroha2-connector): fix flaky tests to solve hyperledger-cacti#2370 …
9aa8c83 
…and hyperledger-cacti#2373

- Use waitForCommit for all transactions used in test suites to prevent spurious CI test failures.

Closes: hyperledger-cacti#2370
Closes: hyperledger-cacti#2373

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz pushed a commit to outSH/cactus that referenced this issue May 3, 2023
@outSH @petermetz
fix(iroha2-connector): fix flaky tests to solve hyperledger-cacti#2370 …
0e16601 
…and hyperledger-cacti#2373

- Use waitForCommit for all transactions used in test suites to prevent spurious CI test failures.

Closes: hyperledger-cacti#2370
Closes: hyperledger-cacti#2373

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz pushed a commit that referenced this issue May 4, 2023
@outSH @petermetz
fix(iroha2-connector): fix flaky tests to solve #2370 and #2373
669b51f 
- Use waitForCommit for all transactions used in test suites to prevent spurious CI test failures.

Closes: #2370
Closes: #2373

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
bug Something isn't working Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) good-first-issue Good for newcomers good-first-issue-400-expert Iroha Bugs/features related to the Iroha ledger connector plugin P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(iroha2-connector): fix flaky tests to solve #2370 and #2373 outSH/cactus
1 participant
@petermetz