Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WalletProxy.sol does not appear to be in the repo #37

Closed
drinkcoffee opened this issue Nov 13, 2019 · 2 comments
Closed

WalletProxy.sol does not appear to be in the repo #37

drinkcoffee opened this issue Nov 13, 2019 · 2 comments
Assignees
@petermetz
Labels
bug Something isn't working

Comments

@drinkcoffee
Copy link

In https://github.com/hyperledger-labs/blockchain-integration-framework/blob/master/src/pluggins/contracts/quorum/Root.sol, "contract Root is WalletProxy". The import implies WalletProxy is in the same directory. However, WalletProxy.sol is not in the directory.
@petermetz
Copy link
Contributor

Thank you @drinkcoffee

cc: @hugo-borne

@petermetz petermetz added the bug Something isn't working label Nov 14, 2019
@petermetz
Copy link
Contributor

Reproduced when
Compiling using default compiler, solidity version: 0.5.11+commit.c082d0b4.Emscripten.clang

@petermetz petermetz self-assigned this Nov 14, 2019
petermetz added a commit to petermetz/cacti that referenced this issue Nov 14, 2019
@petermetz
fix(quorum): eliminates contract syntax errors
1fba521 
Fixes hyperledger-cacti#37

This is just to fix the syntax in the main package, but a refactor is
due on how the contracts are used in genreal:
The examples have code for contract deployment and also are copy pasting
the contracts from the source code, but we could do better by re-using
the code of the examples in the main package itself as a feature.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Nov 14, 2019
@petermetz
fix(quorum): eliminates contract syntax errors
842a25a 
Fixes hyperledger-cacti#37

This is just to fix the syntax in the main package, but a refactor is
due on how the contracts are used in genreal:
The examples have code for contract deployment and also are copy pasting
the contracts from the source code, but we could do better by re-using
the code of the examples in the main package itself as a feature.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Nov 14, 2019
Merged
blefevre pushed a commit to blefevre/blockchain-integration-framework that referenced this issue Feb 4, 2020
@petermetz
Fix/peter.somogyvari/quorum contracts syntax (hyperledger-cacti#42)
f3d5959 
* chore(gitignore): add bin/ directory

The solidity contracts get compiled to that directory when the
VSCode Solidity extension is being used.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>

* fix(quorum): eliminates contract syntax errors

Fixes hyperledger-cacti#37

This is just to fix the syntax in the main package, but a refactor is
due on how the contracts are used in general:
The examples have code for contract deployment and also are copy pasting
the contracts from the source code, but we could do better by re-using
the code of the examples in the main package itself as a feature.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
ryjones pushed a commit that referenced this issue Feb 1, 2023
@VRamakrishna
Merge pull request #37 from sanvenDev/main
6f2fa2e 
Detach Sample Applications from Testnet
ryjones pushed a commit that referenced this issue Feb 1, 2023
@sanven8
Merge pull request #1 from hyperledger-labs/main
32abca8 
Merge pull request #37 from sanvenDev/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petermetz @drinkcoffee