fix(webpack): prod build chokes on upgraded ssh2 binaries #1405 #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-cacti#1405 This removes all webpack minified builds entirely. This has the benefits of faster and stabler builds. What we lose is efficiency of deployments in resource constrained environments where the bundle size would make a difference but the idea here is to crawl, walk and then run with having these minified bundles enabled being the running part of the equation. Root cause ========== If you update the yarn lock file to the latest & greatest it breaks the webpack prod build at the moment with this beauty: ERROR in ../../node_modules/ssh2/lib/protocol/crypto/build/Release/sshcrypto.node 1:0 Module parse failed: Unexpected character '' (1:0) You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders (Source code omitted for this binary file) @ ../../node_modules/ssh2/lib/protocol/crypto.js 30:12-60 @ ../../node_modules/ssh2/lib/client.js 34:29-60 @ ../../node_modules/ssh2/lib/index.js 27:10-32 @ ../../node_modules/docker-modem/lib/ssh.js 1:13-35 @ ../../node_modules/docker-modem/lib/modem.js 6:8-24 @ ../../node_modules/dockerode/lib/docker.js 2:10-33 @ ./src/main/typescript/besu/besu-test-ledger.ts 8:36-56 @ ./src/main/typescript/public-api.ts 20:25-59 @ ./src/main/typescript/index.ts 13:13-36 To Reproduce rm yarn.lock && yarn && yarn configure && yarn build Fixes hyperledger-cacti#1405 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Codecov Report
@@ Coverage Diff @@
## main #1406 +/- ##
=======================================
Coverage 70.39% 70.39%
=======================================
Files 302 302
Lines 10902 10902
Branches 1332 1332
=======================================
Hits 7674 7674
Misses 2526 2526
Partials 702 702 Continue to review full report at Codecov.
|
takeutak
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all webpack minified builds entirely. This has the
benefits of faster and stabler builds.
What we lose is efficiency of deployments in resource constrained
environments where the bundle size would make a difference but
the idea here is to crawl, walk and then run with having these
minified bundles enabled being the running part of the equation.
Root cause
If you update the yarn lock file to the latest & greatest it breaks the
webpack prod build at the moment with this beauty:
ERROR in ../../node_modules/ssh2/lib/protocol/crypto/build/Release/sshcrypto.node 1:0
Module parse failed: Unexpected character '' (1:0)
You may need an appropriate loader to handle this file type, currently no
loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
(Source code omitted for this binary file)
@ ../../node_modules/ssh2/lib/protocol/crypto.js 30:12-60
@ ../../node_modules/ssh2/lib/client.js 34:29-60
@ ../../node_modules/ssh2/lib/index.js 27:10-32
@ ../../node_modules/docker-modem/lib/ssh.js 1:13-35
@ ../../node_modules/docker-modem/lib/modem.js 6:8-24
@ ../../node_modules/dockerode/lib/docker.js 2:10-33
@ ./src/main/typescript/besu/besu-test-ledger.ts 8:36-56
@ ./src/main/typescript/public-api.ts 20:25-59
@ ./src/main/typescript/index.ts 13:13-36
To Reproduce
rm yarn.lock && yarn && yarn configure && yarn build
Fixes #1405
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com