feat(core-api): add weaver protocol buffer definitions #1523 #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
added
Core_API
…cti#1523 Adding the .proto definitions from here as discussed earlier with @VRamakrishna To-do: I skipped the fabric driver proto due to an error on account of the Fabric peer definitions not being present (unresolved import error). Fixes hyperledger-cacti#1523 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
…edger-cacti#1523 Updated Weaver protos README and imported latest schema additions Fixes hyperledger-cacti#1523 Signed-off-by: VRamakrishna <vramakr2@in.ibm.com>
petermetz
force-pushed
the
feat-1523-rama
branch
from
7ca45d0
to
2949140
Compare
|
@VRamakrishna Thank you for your help and cooperation! I'm excited about us working together! |
takeutak
approved these changes
Nov 18, 2021
|
@petermetz |
izuru0
reviewed
Nov 18, 2021
@izuru0 There's no implementation to it yet so in that sense the answer is an implicit no. If we do manage to get any parts of the implementation in prior to 1.0 as well, then my suggestion will be to mark those as beta/dev preview features, meaning that it would be accessible at runtime, but in the documentation marked as not yet production ready and then we can maybe roll it out at a 1.1 release or whenever we feel ready. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's two commits in this PR on purpose, one is to hold the sign-off from Rama and the other one is the admin chores performed prior to that sign-off.
This is an important milestone for us (Weaver and Cactus maintainers) working together.
Commit 1
Updated Weaver protos README and imported latest schema additions
Fixes #1523
Signed-off-by: VRamakrishna vramakr2@in.ibm.com
Commit 2
feat(core-api): add weaver protocol buffer definitions #1523
Adding the .proto definitions from here as discussed earlier with @VRamakrishna
To-do: I skipped the fabric driver proto due to an error on account of the
Fabric peer definitions not being present (unresolved import error).
Fixes #1523
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com