-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-ledger-connector-fabric-socketio): upgrade Fabric due to jsrsasign #1800
Conversation
67fbb63
to
67b6ac8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@petermetz Can you approve and merge this please? It's blocking PR next in line :) |
@outSH Thank you for the information. I'm working on the reviews as fast as I can. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petermetz Oh, right! I'm currently working on putting them into containers and monorepo build right now, and for some reasons assumed it's already done in my mind :)
Thank you! I vote for exact versions, regardless of it being more effort to manually bump them later or not.
@outSH No worries, I mix up my own PRs all the time. Extending on my earlier answer: the yarn.lock wouldn't save us in some edge cases either and because of that I always ask people to specify exact versions instead of ranges (so I would've asked the same thing even if the packages were part of the monorepo already)
OK. Shall I switch to exact versions for every dependency in
package.json
? Only fabric one? Shall I do this for allpackage.json
affected by this PR?
That can be part of another PR, I dont' want to complicate this one any further.
Sure, not rushing, I just wanted to put this PR to the front ;) Thank's for quick handling other PR as well, btw |
1726aa4
to
cc06aa9
Compare
…srsasign Revert fabric sdk package change from PR hyperledger#1754 Closes: hyperledger#1799 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
cc06aa9
to
9dbadf6
Compare
Revert fabric sdk package change from PR #1754
Closes: #1799
Signed-off-by: Michal Bajer michal.bajer@fujitsu.com
After change: