refactor(docs): dockerize catrade and fabric validator #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@izuru0 @takeutak @petermetz - Please review |
petermetz
requested review from
izuru0 and
takeutak
and removed request for
jonathan-m-hamilton
petermetz
requested changes
Jan 27, 2022
outSH
force-pushed
the
fabric_validator_docker_pr
branch
from
c5442c9
to
b48c30e
Compare
|
This PR/issue depends on: |
outSH
force-pushed
the
fabric_validator_docker_pr
branch
from
b48c30e
to
76b9069
Compare
petermetz
changed the title
petermetz
changed the title
Cartrade example will be setup in docker-compose, updated the readme with new instructions. Fabric validator runs in container as well. Removed obsolete scripts, changed them where needed. Build artifacts are not put directly in root dist/ dir anymore (it's still used by apps not dockerized yet, though, but will be changed in future commits). Validator configuration is made cartrade-specific, this will be done in the same way for other sample apps in future commits. Some setup changed were necesary in other samples as well, all should work like before. Added small patch in fabric-all-in-one to support cartrade scenario (endorsment from peer from single org). Updated indy clientbase base image because it didn't work with ppa:deadsnakes anymore. Closes: hyperledger-cacti#1805 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
force-pushed
the
fabric_validator_docker_pr
branch
from
76b9069
to
39e81d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dist/dir anymore (it's still used by apps not dockerized yet, though, but will be changed in future commits).ppa:deadsnakesanymore.Closes: #1805
Signed-off-by: Michal Bajer michal.bajer@fujitsu.com
TODO (in future PR)
@hyperledger/cactus-cmd-socket-server(will not use this long fragile path in the future)Depends on #1800