fix(deps): force minimist >=1.2.6 for CVE-2021-44906 #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that yarn will only install 1.2.6 or newer versions for minimist. The proper fix would be to have the dependencies issue releases which upgrade their own (transitive) dependencies of minimist so that we don't have to explicitly force it here, but at the time of this writing these upgrades in our direct dependencies are just not available yet. Fixes hyperledger-cacti#1943 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
requested review from
izuru0,
jagpreetsinghsasan and
takeutak
and removed request for
jonathan-m-hamilton
petermetz
added
dependencies
jagpreetsinghsasan
approved these changes
Mar 23, 2022
takeutak
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that yarn will only install 1.2.6 or newer versions for
minimist.
The proper fix would be to have the dependencies issue releases
which upgrade their own (transitive) dependencies of minimist
so that we don't have to explicitly force it here, but at the time
of this writing these upgrades in our direct dependencies are just
not available yet.
Fixes #1943
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com