Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd-api-server): disallow running on older than Node 12 but provi… #210

Conversation

petermetz
Copy link
Contributor

…de optional override

  1. Node 10 is no longer the LTS version
  2. Node 10 does not properly support TLS v1.3

fix #150

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

@petermetz petermetz added dependencies Pull requests that update a dependency file Security Related to existing or potential security vulnerabilities labels Jun 26, 2020
@petermetz petermetz force-pushed the feat/cmd-api-server/refuse-node10-by-default-github-issue-150 branch from 790f013 to cb966da Compare June 26, 2020 06:32
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…de optional override

1. Node 10 is no longer the LTS version
2. Node 10 does not properly support TLS v1.3
3. The CI script will no longer run against Node 10 just 12 and 14.

fix hyperledger-cacti#150

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the feat/cmd-api-server/refuse-node10-by-default-github-issue-150 branch from cb966da to a4b0fa6 Compare June 30, 2020 22:44
Copy link
Contributor

@sfuji822 sfuji822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfuji822 sfuji822 merged commit 332b306 into hyperledger-cacti:master Jun 30, 2020
@petermetz petermetz deleted the feat/cmd-api-server/refuse-node10-by-default-github-issue-150 branch June 30, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Security Related to existing or potential security vulnerabilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(cmd-api-server): Refuse to run on NodeJS 10 by default
3 participants