test: migrate run-tx-with-ws-ds, keychain-aws-sm tests from Tap to Jest #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
petermetz
changed the title
petermetz
force-pushed
the
test-jestify-keychain-aws-sm-and-run-tx-with-ws-ids-tests
branch
from
e2f3b75
to
c19f39e
Compare
outSH
approved these changes
Jun 14, 2024
There's still about a hundred test cases to be migrated so I'm combining a few at a time in the pull requests to reduce the CI resource consumption. They are fairly boilerplate changes that usually follow the exact same pattern so it's fairly easy to review with that in mind (hopefully) despite the slightly larger size. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
test-jestify-keychain-aws-sm-and-run-tx-with-ws-ids-tests
branch
from
c19f39e
to
9d18ceb
Compare
petermetz
deleted the
test-jestify-keychain-aws-sm-and-run-tx-with-ws-ids-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still about a hundred test cases to be migrated so I'm combining a
few at a time in the pull requests to reduce the CI resource consumption.
They are fairly boilerplate changes that usually follow the exact same
pattern so it's fairly easy to review with that in mind (hopefully) despite
the slightly larger size.
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.