Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(release-management): fix checklist and OpenAPI spec version bumps #3318

Conversation

petermetz
Copy link
Contributor

  1. After this change the steps within the release management documentation should
    work without issues.
  2. Currently the process is (was) broken due to our reliance on URL references
    within the OpenAPI specifications which created a chicken-egg problem with the
    release tag issuance and the building of the source code to be released.

This change depends on the other pull requests that are refactoring the cross-package
OpenAPI specification references:

Depends on #3288
Depends on #3315

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

1. After this change the steps within the release management documentation should
work without issues.
2. Currently the process is (was) broken due to our reliance on URL references
within the OpenAPI specifications which created a chicken-egg problem with the
release tag issuance and the building of the source code to be released.

This change depends on the other pull requests that are refactoring the cross-package
OpenAPI specification references:

Depends on hyperledger-cacti#3288
Depends on hyperledger-cacti#3315

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the build-fix-release-managment-and-openapi-version-bumps branch from 36eedc6 to 25de5b6 Compare June 14, 2024 15:00
Copy link

This PR/issue depends on:

  • hyperledger/cacti#3288
  • hyperledger/cacti#3315
    By Dependent Issues (🤖). Happy coding!

@petermetz petermetz merged commit 6bdcedf into hyperledger-cacti:main Jun 14, 2024
143 of 149 checks passed
@petermetz petermetz deleted the build-fix-release-managment-and-openapi-version-bumps branch June 14, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants