Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gitguardian ignore paths #3334

Closed
wants to merge 2 commits into from

Conversation

sandeepnRES
Copy link
Contributor

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Signed-off-by: Sandeep Nishad <sandeep.nishad1@ibm.com>
Signed-off-by: Sandeep Nishad <sandeep.nishad1@ibm.com>
Copy link

gitguardian bot commented Jun 19, 2024

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11762267 Triggered Generic Private Key 12e51d2 weaver/core/drivers/fabric-driver/wallet-network1/relay.id View secret
- Generic Private Key 12e51d2 weaver/core/drivers/fabric-driver/wallet-network1/relay.id View secret
- Generic Private Key 12e51d2 weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/org3/msp/keystore/IssuerRevocationPrivateKey View secret
11762277 Triggered Generic Private Key 12e51d2 weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/org3/msp/keystore/a6ca52b519199223f12b72c54944ce32628f34de382e118e6a7cf9737394fb45_sk View secret
11762279 Triggered Generic Private Key 12e51d2 weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/org3/msp/keystore/a7fa347b343cb9b9d4f13fade85803d6c19a0e83fb628c636530a39c4fbc2585_sk View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant