feat(corda-connector): scp jars to nodes #621 #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
force-pushed
the
feat-621
branch
4 times, most recently
from
51e5421
to
b73192d
Compare
petermetz
force-pushed
the
feat-621
branch
3 times, most recently
from
d40a67d
to
3431d8e
Compare
takeutak
previously approved these changes
Mar 23, 2021
petermetz
force-pushed
the
feat-621
branch
3 times, most recently
from
dadfee9
to
4ea4285
Compare
takeutak
approved these changes
Mar 24, 2021
kikoncuo
approved these changes
Mar 25, 2021
petermetz
force-pushed
the
feat-621
branch
2 times, most recently
from
a589002
to
531bfae
Compare
With this change the users of the Corda AIO image can decide which nodes to launch (A,B,C,Notary) exactly. Adds scripts to launch individual nodes as needed. Before this we could only launch all the nodes at once which did not work out well because it caused race conditions in the cordapp jar deployment code. This revision is tagged in the container registry as: hyperledger/cactus-corda-4-6-all-in-one-obligation:2021-03-19-feat-686 Fixes hyperledger-cacti#686 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Implements transferring the cordapp jar files onto Corda nodes via SSH+SCP. It supports deploying to multiple nodes in a single request via an array of deployment configuration parameters that the caller can specify. Credentials are travelling on the wire in plain text right now which is of course unacceptable and a follow-up issue has been created to rectify this by adding keychain support or some other type of solution that does not make it necessary for the caller to send up SSH and RPC credentials with their deployment request. Another thing that we'll have to fix prior to GA is that right now there is no SSH host key verification. For development mode Corda nodes: There's possibility to declare which cordapp jar contains database migrations for H2 and the deployment endpoint can run these as well. The graceful shutdown method is implemented on our RPC connection class because this is not yet supported on the version of Corda that we are targeting with the connector (v4.5). The new test that verifies that all is working well is called deploy-cordapp-jars-to-nodes.test.ts and what it does is very similar to the older test called jvm-kotlin-spring-server.test.ts but this one does its invocations with a contract that has been built and deployed from scratch not like the old test which relied on the jars already being present in the AIO Corda container by default. The current commit is also tagged in the container registry as: hyperledger/cactus-connector-corda-server:2021-03-16-feat-621 Fixes hyperledger-cacti#621 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
|
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies (need to be reviewed and merged first)
Depends on #657
Depends on #687
Depends on #688
Depends on #689
Depends on #690
Depends on #691
Depends on #692
Depends on #693
Depends on #656
Commit to be reviewed
Fixes #621